Skip to content

[Internal QA] Unmask 'Close Account' Dialog in FullStory recordings #58314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

[Internal QA] Unmask 'Close Account' Dialog in FullStory recordings #58314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21119c3
Unmask Close Account dialog in FullStory
Shahidullah-Muffakir Mar 12, 2025
9e026c8
replace namespace imports with named imports
Shahidullah-Muffakir Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions src/pages/settings/Security/CloseAccountPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Str} from 'expensify-common';
import React, {useEffect, useState} from 'react';
import React, {useEffect, useLayoutEffect, useState} from 'react';
import {View} from 'react-native';
import {useOnyx} from 'react-native-onyx';
import ConfirmModal from '@components/ConfirmModal';
Expand All @@ -13,11 +13,12 @@ import Text from '@components/Text';
import TextInput from '@components/TextInput';
import useLocalize from '@hooks/useLocalize';
import useThemeStyles from '@hooks/useThemeStyles';
import {parseFSAttributes} from '@libs/Fullstory';
import Navigation from '@libs/Navigation/Navigation';
import * as ValidationUtils from '@libs/ValidationUtils';
import {getFieldRequiredErrors} from '@libs/ValidationUtils';
import variables from '@styles/variables';
import * as CloseAccount from '@userActions/CloseAccount';
import * as User from '@userActions/User';
import {clearError} from '@userActions/CloseAccount';
import {closeAccount} from '@userActions/User';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import INPUT_IDS from '@src/types/form/CloseAccountForm';
Expand All @@ -35,14 +36,22 @@ function CloseAccountPage() {
// nothing runs on mount and we pass empty dependencies to prevent this from running on every re-render.
// TODO: We should refactor this so that the data in instead passed directly as a prop instead of "side loading" the data
// here, we left this as is during refactor to limit the breaking changes.
useEffect(() => () => CloseAccount.clearError(), []);
useEffect(() => () => clearError(), []);

/**
* Extracts values from the non-scraped attribute WEB_PROP_ATTR at build time
* to ensure necessary properties are available for further processing.
* Reevaluates "fs-class" to dynamically apply styles or behavior based on
* updated attribute values.
*/
useLayoutEffect(parseFSAttributes, []);

const hideConfirmModal = () => {
setConfirmModalVisibility(false);
};

const onConfirm = () => {
User.closeAccount(reasonForLeaving);
closeAccount(reasonForLeaving);
hideConfirmModal();
};

Expand All @@ -60,7 +69,7 @@ function CloseAccountPage() {

const validate = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM> => {
const userEmailOrPhone = session?.email ? formatPhoneNumber(session.email) : null;
const errors = ValidationUtils.getFieldRequiredErrors(values, ['phoneOrEmail']);
const errors = getFieldRequiredErrors(values, ['phoneOrEmail']);

if (values.phoneOrEmail && userEmailOrPhone && sanitizePhoneOrEmail(userEmailOrPhone) !== sanitizePhoneOrEmail(values.phoneOrEmail)) {
errors.phoneOrEmail = translate('closeAccountPage.enterYourDefaultContactMethod');
Expand Down Expand Up @@ -88,7 +97,11 @@ function CloseAccountPage() {
style={[styles.flexGrow1, styles.mh5]}
isSubmitActionDangerous
>
<View style={[styles.flexGrow1]}>
<View
fsClass={CONST.FULL_STORY.UNMASK}
testID={CONST.FULL_STORY.UNMASK}
style={[styles.flexGrow1]}
>
<Text>{translate('closeAccountPage.reasonForLeavingPrompt')}</Text>
<InputWrapper
InputComponent={TextInput}
Expand Down