Skip to content

Use showStates in report params so that report state filters work in OldDot #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 14, 2021

Conversation

TomatoToaster
Copy link
Contributor

@TomatoToaster TomatoToaster commented Oct 13, 2021

CC: @yuwenmemon

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180872

Tests

For this to work locally, this PR is also needed https://github.com/Expensify/Web-Expensify/pull/32177/files

Also I couldn't get the dang bank set up to work I got stuck on adding an address. So instead I changed this line to just be true:

const hasVBA = achState === BankAccount.STATE.OPEN;

In staging we already have accounts with VBA set up.

QA Steps

  1. Get a user on NewDot, with a Workspace and VBA set up on their account.
  2. Through workspace settings go to Pay bills, Reimburse receipts, and View Unpaid Invoices verify that when you click on those, you are redirected to OldDot with the correct report filters applies:

Pay bills > opens a new browser tab in OldDot on the reports page, filtered by the relevant workspace and report type bills in the processing and approved states.
Reimburse receipts > Opens a new browser tab and links to the OldDot Reports page filtered by the relevant workspace and expense reports in the Closed state awaiting reimbursement.
View unpaid invoices > opens a new browser tab in OldDot on the reports page, filtered by the relevant workspace and report type invoices in the processing state awaiting payment.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image
image

image
image

image
image

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@TomatoToaster TomatoToaster force-pushed the amal-fix-report-filtering branch from 5e7beb4 to f27300f Compare October 13, 2021 23:52
@TomatoToaster TomatoToaster marked this pull request as ready for review October 14, 2021 00:11
@TomatoToaster TomatoToaster requested a review from a team as a code owner October 14, 2021 00:11
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team October 14, 2021 00:11
@yuwenmemon yuwenmemon merged commit ec48d35 into main Oct 14, 2021
@yuwenmemon yuwenmemon deleted the amal-fix-report-filtering branch October 14, 2021 01:17
github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
Use showStates in report params so that report state filters work in OldDot

(cherry picked from commit ec48d35)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.7-16 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants