-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Use showStates in report params so that report state filters work in OldDot #5829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
5e7beb4
to
f27300f
Compare
Use showStates in report params so that report state filters work in OldDot (cherry picked from commit ec48d35)
🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.7-16 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
🚀 Deployed to staging by @yuwenmemon in version: 1.1.7-25 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
CC: @yuwenmemon
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180872
Tests
For this to work locally, this PR is also needed https://github.com/Expensify/Web-Expensify/pull/32177/files
Also I couldn't get the dang bank set up to work I got stuck on adding an address. So instead I changed this line to just be true:
App/src/pages/workspace/WorkspacePageWithSections.js
Line 55 in ab5acf4
In staging we already have accounts with VBA set up.
QA Steps
Pay bills
,Reimburse receipts
, andView Unpaid Invoices
verify that when you click on those, you are redirected to OldDot with the correct report filters applies:Tested On
Screenshots
Web