fix(lhn): update for deleted messages

[jaydamani]

Explanation of Change

When last message of a report is deleted use getReportLastMessage instead of report.lastMessageText

Fixed Issues

$ #57694
PROPOSAL: #57694 (comment)

Tests

User A logged in on the main testing device, User B - on secondary device

1. Navigate to staging.new.expensify.com and log in as a gmail user
2. As User A, create a chat with User B, sen some messages
3. As User A, navigate to another chat
4. As User B, create manual expense in the chat with user A
5. User A, observe the LHN for the chat. Make sure, the chat is bold and the expense action is shown (User A owes $..). Do not open the chat.
6. User B, delete the expense
7. User A, observe the LHN again

• Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mweb-a.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[jaydamani]

After deleting an expense, the GBR is not removed so looking into that and also need to check failing tests

[jaydamani]

I was away today, so could not focus on this. I will pick it up as a priority tomorrow and share the updates here.

[jaydamani]

@brunovjk while testing I found that the GBR stays for user A even after the expenses are deleted by user B. It is happening from here due to check for hasOutstandingChildRequest in report which is true even after expense is deleted.

https://github.com/expensify/app/blob/9c1f0dc370133c6b56c688c8dde2efbc3ccba652/src/libs/ReportUtils.ts#L3175-L3180

Similarly, if user B sends a message mentioning user A then deletes it. It stays as unread for user A due to logic in isUnreadWithMention

https://github.com/expensify/app/blob/9c1f0dc370133c6b56c688c8dde2efbc3ccba652/src/libs/ReportUtils.ts#L3120-L3128

For both of these, I think we should update backend because the indicators can be for older report actions that are not yet loaded in front-end.
What are your thoughts?

[brunovjk]

Great! I will review it first thing tomorrow and let you know. Thank you :D

[brunovjk]

Thank you @jaydamani, I think you RCA make sense, I asked @thienlnam to check for us. Thank you.

[jaydamani]

Minor bump @thienlnam

[thienlnam]

Sorry, was OOO for a couple days and catching up on things - I'll try to take a look tommorow

[melvin-bot]

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jaydamani]

@thienlnam minor bump for updates

[thienlnam]

To confirm, when an expense is deleted we want the parent report to have hasOutstandingChildRequest set to false?

Similarly for a mention - if a mention is deleted we should have isUnreadWithMention set to false for the report the comment was in?

[jaydamani]

To confirm, when an expense is deleted we want the parent report to have hasOutstandingChildRequest set to false?

Yes but if there are any other outstanding child request then it should not changed

Similarly for a mention - if a mention is deleted we should have isUnreadWithMention set to false for the report the comment was in?

Yes and also update lastMentionedTime to be whatever is the new last mentioned time.

cc: @brunovjk

[thienlnam]

Okay sounds good, I've started looking into it - and have made some progress. Will aim to get a PR into review next week. Have a few other priorities going on

[thienlnam]

Okay, looks like someone else got to the mention issue so that should be fixed. Still working on the deleted transaction update

[brunovjk]

@jaydamani Could you merge main here? I want to do some testing.

[jaydamani]

@brunovjk Merged with main, let me know if any updates are required

[jaydamani]

Looking into this and the expense report looks incorrect for the receiver/user A. It shows only the total but it should be a single expense report
@brunovjk does this happen for you as well?

[brunovjk]

Let me check, I'm going back to the office now.

[brunovjk]

Looking into this and the expense report looks incorrect for the receiver/user A. It shows only the total but it should be a single expense report @brunovjk does this happen for you as well?

Sorry for the delay @jaydamani. I believe so, is this the issue you are referring to:

Screen.Recording.2025-04-21.at.18.31.15.mov

I don't know if it is within the scope of our original issue, what do you think? But anyway I will check if there is not already a reported issue.

[jaydamani]

@brunovjk I meant the report total shows 2$ but there are no expenses or any other detail but I also can't replicate that anymore so I think it is resolved and yeah it was probably out of scope for this PR. I think the only thing left here is the backend PR

[brunovjk]

I think I misunderstood then. But anyway I'll ask, in slack, for them to confirm the "Expected result" of these situations. Thanks for the re-test, let's wait for Jack with the changes in the backend then.

[brunovjk]

@thienlnam any update for us here? Thanks.

[thienlnam]

Haven't had a chance to look into this yet unfortunately

[jaydamani]

@thienlnam any updates here 👀

[thienlnam]

Still no update yet, but I've gotten through some of the things last week and so should have more time this week to take a look

[thienlnam]

Screen.Recording.2025-05-09.at.6.39.47.PM.mov

Found the issue, and sending a PR into review!

[thienlnam]

Alright, BE fix is live now

[brunovjk]

Great! @jaydamani could you please merge main, I just want to do one last check and we can go. Thanks.

[jaydamani]

@brunovjk merged main

[jaydamani]

Just an heads up, getTransaction deprecation is already being handled here

[brunovjk]

@jaydamani did you test it again? It seems that the initial issue is back here:

Screen.Recording.2025-05-16.at.12.26.23.mov

I just gave it a quick test, I can investigate it further later.

[jaydamani]

@brunovjk Sorry I couldn't test earlier.
Tested now and could not replicate. Please review if my steps are correct.

Record_select-area_20250518165142.mp4

[brunovjk]

Strange, now that I tested it everything works fine @jaydamani. Sorry, I must have done something wrong last time

[brunovjk]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Uploading 58957_android_native.mov…

Android: mWeb Chrome

Uploading 58957_android_web.mov…

iOS: HybridApp

Uploading 58957_ios_native.mov…

iOS: mWeb Safari

Uploading 58957_ios_web.mov…

MacOS: Chrome / Safari

Uploading 58957_web_chrome.mov…

MacOS: Desktop

Uploading 58957_web_desktop.mov…

[brunovjk]

LGTM. Notes:

• We just have to pay attention to this comment
• The videos in the "Screenshots/Videos" section of my checklist were not uploaded, something is happening with my internet, I will come back tomorrow and try to upload again.

[thienlnam]

Nice!

[melvin-bot]

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[thienlnam]

Failing due to

We just have to pay attention to this #58127 (comment)

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.