fix: decode bank param to get all cards correctly #58101

koko57 · 2025-03-10T15:25:24Z

Explanation of Change

Fixed Issues

$ #58005
PROPOSAL:

Tests

PREREQUISITES: Company Cards enabled, Direct feed added
in the Browser (Mac/mWeb)

Assign a card to the workspace member
Open newly assigned card details
Refresh the page
Verify that the card details are displayed correctly - not the "hmmm not here" page

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PREREQUISITES: Company Cards enabled, Direct feed added
in the Browser (Mac/mWeb)

Assign a card to the workspace member
Open newly assigned card details
Refresh the page
Verify that the card details are displayed correctly - not the "hmmm not here" page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-03-10.at.16.58.47.mp4

MacOS: Desktop

melvin-bot · 2025-03-11T07:20:06Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2025-03-11T12:01:03Z

@koko57 I can test the company card details page since I’m added to a workspace where a card is available. However, I’m unable to test WorkspaceCompanyCardAccountSelectCardPage. We’re using bank from route.params, so can you confirm if we also need to fix decodeURIComponent for that page?

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Lines 28 to 31 in 75ab857

    
           function WorkspaceCompanyCardAccountSelectCardPage({route}: WorkspaceCompanyCardAccountSelectCardProps) { 
        
               const {translate} = useLocalize(); 
        
               const styles = useThemeStyles(); 
        
               const {policyID, cardID, bank} = route.params;

koko57 · 2025-03-11T12:03:12Z

@jayeshmangwani good point! thanks! Probably we need it there too. I will check it and change it if necessary

jayeshmangwani · 2025-03-11T12:08:19Z

There’s one more page to confirm, do we need to add it there as well? On AssignCardFeedPage, we're using feed from route.params and passing it to AssigneeStep, BankConnection, and CardSelectionStep. However, I’m not sure if we can hard refresh those pages.

App/src/pages/workspace/companyCards/assignCard/AssignCardFeedPage.tsx

Lines 22 to 26 in 75ab857

    
           function AssignCardFeedPage({route, policy}: AssignCardFeedPageProps) { 
        
               const [assignCard] = useOnyx(ONYXKEYS.ASSIGN_CARD); 
        
               const currentStep = assignCard?.currentStep; 
        
               const feed = route.params?.feed;

koko57 · 2025-03-11T13:06:51Z

@jayeshmangwani I've changed the param in the places you've found, I've also found one another place where it should be changed

jayeshmangwani · 2025-03-11T15:33:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

Changes LGTM 🚀

mountiny

Great, thank you!

OSBotify · 2025-03-14T02:17:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-17T12:01:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2025-03-18T14:14:09Z

Works!

2025-03-18_10-13-53.mp4

github-actions · 2025-03-18T21:28:52Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.14-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: decode bank param to get all cards correctly

a22b41e

koko57 marked this pull request as ready for review March 11, 2025 07:20

koko57 requested a review from a team as a code owner March 11, 2025 07:20

melvin-bot bot requested review from jayeshmangwani and removed request for a team March 11, 2025 07:20

fix: replace with decode in other locations

bf5be3d

fix: eslint

b0ae197

jayeshmangwani approved these changes Mar 11, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 11, 2025 15:34

mountiny assigned koko57 Mar 14, 2025

mountiny added the InternalQA This pull request required internal QA label Mar 14, 2025

mountiny approved these changes Mar 14, 2025

View reviewed changes

mountiny merged commit 04b9304 into Expensify:main Mar 14, 2025
17 checks passed

github-actions bot mentioned this pull request Mar 17, 2025

Deploy Checklist: New Expensify 2025-03-17 #58550

Closed

72 tasks

melvin-bot bot mentioned this pull request Mar 18, 2025

[Due for payment 2025-03-25] [$250] mWeb - AMEX Cards - Refreshing the card details page results in "hmm not here" page. #58005

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: decode bank param to get all cards correctly #58101

fix: decode bank param to get all cards correctly #58101

Uh oh!

koko57 commented Mar 10, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 11, 2025

Uh oh!

jayeshmangwani commented Mar 11, 2025

Uh oh!

koko57 commented Mar 11, 2025

Uh oh!

jayeshmangwani commented Mar 11, 2025

Uh oh!

koko57 commented Mar 11, 2025

Uh oh!

jayeshmangwani commented Mar 11, 2025

Uh oh!

jayeshmangwani left a comment

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

joekaufmanexpensify commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

Uh oh!

fix: decode bank param to get all cards correctly #58101

fix: decode bank param to get all cards correctly #58101

Uh oh!

Conversation

koko57 commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 11, 2025

Uh oh!

jayeshmangwani commented Mar 11, 2025

Uh oh!

koko57 commented Mar 11, 2025

Uh oh!

jayeshmangwani commented Mar 11, 2025

Uh oh!

koko57 commented Mar 11, 2025

Uh oh!

jayeshmangwani commented Mar 11, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

joekaufmanexpensify commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

Uh oh!

koko57 commented Mar 10, 2025 •

edited

Loading