Skip to content

Fix : Investigate Profiling: iOS - Chrome/Safari and MacOS - Safari #58065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Fix : Investigate Profiling: iOS - Chrome/Safari and MacOS - Safari #58065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f0cdb0
add function to hide profiling tool
M00rish Mar 7, 2025
d174b20
update according to review and fix lint
M00rish Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/components/TestToolsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import React from 'react';
import React, {useMemo} from 'react';
import {View} from 'react-native';
import {useOnyx} from 'react-native-onyx';
import useLocalize from '@hooks/useLocalize';
import useStyleUtils from '@hooks/useStyleUtils';
import useThemeStyles from '@hooks/useThemeStyles';
import useWindowDimensions from '@hooks/useWindowDimensions';
import {getBrowser, isChromeIOS} from '@libs/Browser';
import Navigation from '@navigation/Navigation';
import toggleTestToolsModal from '@userActions/TestTool';
import CONST from '@src/CONST';
Expand All @@ -26,6 +27,17 @@ function TestToolsModal() {
const styles = useThemeStyles();
const {translate} = useLocalize();

const shouldShowProfileTool = useMemo(() => {
const browser = getBrowser();
const isSafariOrFirefox = browser === CONST.BROWSER.SAFARI || browser === CONST.BROWSER.FIREFOX;

if (isSafariOrFirefox || isChromeIOS()) {
return false;
}

return true;
}, []);

return (
<Modal
isVisible={!!isTestToolsModalOpen}
Expand All @@ -39,7 +51,7 @@ function TestToolsModal() {
>
{translate('initialSettingsPage.troubleshoot.releaseOptions')}
</Text>
<ProfilingToolMenu />
{shouldShowProfileTool && <ProfilingToolMenu />}
<ClientSideLoggingToolMenu />
{!!shouldStoreLogs && (
<TestToolRow title={translate('initialSettingsPage.troubleshoot.debugConsole')}>
Expand Down