[CP Staging] fix: unable hold expense from reports #57979

linhvovan29546 · 2025-03-07T04:44:22Z

Explanation of Change

Fixed Issues

$ #57972
PROPOSAL: #57972 (comment)

Tests

Go to staging.new.expensify.com
Open any chat.
Submit an expense.
Go to Reports.
Select the expense from Step 3 via checkbox.
Open dropdown menu.
Click Hold.
Enter reason and save it.
Click on the expense.
Click on the report header.
Verify the expense will be held.

Verify that no errors appear in the JS console

Offline tests

Same test above

QA Steps

Same test above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-07.at.13.35.19.mov

Android: mWeb Chrome

Screen.Recording.2025-03-07.at.11.57.55.mov

iOS: Native

Screen.Recording.2025-03-07.at.11.56.06.mov

iOS: mWeb Safari

Screen.Recording.2025-03-07.at.11.52.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-07.at.11.50.04.mov

MacOS: Desktop

Screen.Recording.2025-03-07.at.11.53.29.mov

melvin-bot · 2025-03-07T05:02:13Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-03-07T07:24:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-07.at.21.35.22.mov

Android: mWeb Chrome

Screen.Recording.2025-03-07.at.21.32.45.mov

iOS: Native

Screen.Recording.2025-03-07.at.21.33.40.mov

iOS: mWeb Safari

Screen.Recording.2025-03-07.at.21.34.09.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-07.at.21.30.56.mov

MacOS: Desktop

Screen.Recording.2025-03-07.at.21.31.30.mov

DylanDylann · 2025-03-07T07:46:48Z

@linhvovan29546 We haven't removed SCREENS.SEARCH.ROOT, it is still used in our App in some places. And isSearchTopmostFullScreenRoute function is used in many places. Why do you think this change is compatible with all usage places of isSearchTopmostFullScreenRoute

linhvovan29546 · 2025-03-07T07:56:38Z

@DylanDylann I have tested several places where isSearchTopmostFullScreenRoute is used, and it works well (except for IOU actions, which I haven't tested yet). As i know that we added SEARCH_FULLSCREEN_NAVIGATOR to the top of the stack (previously SCREENS.SEARCH.ROOT).

DylanDylann · 2025-03-07T07:58:31Z

@linhvovan29546 Could you please dishtinguish SEARCH_FULLSCREEN_NAVIGATOR and SCREENS.SEARCH.ROOT. When should we use SEARCH_FULLSCREEN_NAVIGATOR? When should we use SCREENS.SEARCH.ROOT?

DylanDylann · 2025-03-07T07:59:25Z

I think we need to deep dive into the offending PR to understand it thoroughly

linhvovan29546 · 2025-03-07T08:04:57Z

The SCREENS.SEARCH.ROOT will always be inside SEARCH_FULLSCREEN_NAVIGATOR
The code changes in isSearchTopmostFullScreenRoute are similar to isReportTopmostSplitNavigator because both are root stacks

DylanDylann · 2025-03-07T14:05:05Z

@linhvovan29546 Thanks for your update. Your PR looks fine. But let's me recheck this one more time

DylanDylann · 2025-03-07T14:41:41Z

Note regarding the implementation: isSearchTopmostFullScreenRoute will return true for both Search_Root and Search_Report routes, I've reviewed the offending PR and confirmed this behavior is acceptable.
@mollfpr Thus, I think we are good to go

mollfpr

LGTM 🚀

Thank you guys for the quick PR and review!

OSBotify · 2025-03-07T14:53:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…xpense-from-report fix: unable hold expense from reports (cherry picked from commit 3c6cafe) (CP triggered by puneetlath)

github-actions · 2025-03-07T16:16:06Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-10T21:13:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: unable hold expense from reports

dfc27c0

This comment was marked as resolved.

Sign in to view

linhvovan29546 marked this pull request as ready for review March 7, 2025 05:02

linhvovan29546 requested a review from a team as a code owner March 7, 2025 05:02

melvin-bot bot requested a review from DylanDylann March 7, 2025 05:02

melvin-bot bot removed the request for review from a team March 7, 2025 05:02

This comment was marked as resolved.

Sign in to view

DylanDylann approved these changes Mar 7, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr March 7, 2025 14:36

mollfpr approved these changes Mar 7, 2025

View reviewed changes

mollfpr assigned linhvovan29546 Mar 7, 2025

mollfpr merged commit 3c6cafe into Expensify:main Mar 7, 2025
18 of 19 checks passed

mollfpr changed the title ~~fix: unable hold expense from reports~~ [CP Staging] fix: unable hold expense from reports Mar 7, 2025

mollfpr mentioned this pull request Mar 7, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks

OSBotify pushed a commit that referenced this pull request Mar 7, 2025

Merge pull request #57979 from linhvovan29546/fix/57972-unable-hold-e…

0f12a76

…xpense-from-report fix: unable hold expense from reports (cherry picked from commit 3c6cafe) (CP triggered by puneetlath)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 7, 2025

lanitochka17 mentioned this pull request Mar 7, 2025

[Due for payment 2025-03-25][$250] Android - Expense - Tapping back button after holding expense, leads to inbox instead of chat #58028

Closed

8 tasks

melvin-bot bot mentioned this pull request Mar 10, 2025

[Due for payment 2025-03-21] [Due for payment 2025-03-17] [$250] Reports - Unable to hold expense from Reports #57972

Closed

8 tasks

linhvovan29546 deleted the fix/57972-unable-hold-expense-from-report branch March 18, 2025 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CP Staging] fix: unable hold expense from reports #57979

[CP Staging] fix: unable hold expense from reports #57979

Uh oh!

linhvovan29546 commented Mar 7, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

melvin-bot bot commented Mar 7, 2025

Uh oh!

This comment was marked as resolved.

DylanDylann commented Mar 7, 2025 •

edited

Loading

Uh oh!

DylanDylann commented Mar 7, 2025 •

edited

Loading

Uh oh!

linhvovan29546 commented Mar 7, 2025

Uh oh!

DylanDylann commented Mar 7, 2025

Uh oh!

DylanDylann commented Mar 7, 2025

Uh oh!

linhvovan29546 commented Mar 7, 2025 •

edited

Loading

Uh oh!

DylanDylann commented Mar 7, 2025

Uh oh!

DylanDylann commented Mar 7, 2025 •

edited

Loading

Uh oh!

mollfpr left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

Uh oh!

[CP Staging] fix: unable hold expense from reports #57979

[CP Staging] fix: unable hold expense from reports #57979

Uh oh!

Conversation

linhvovan29546 commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

melvin-bot bot commented Mar 7, 2025

Uh oh!

This comment was marked as resolved.

DylanDylann commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Mar 7, 2025

Uh oh!

DylanDylann commented Mar 7, 2025

Uh oh!

DylanDylann commented Mar 7, 2025

Uh oh!

linhvovan29546 commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Mar 7, 2025

Uh oh!

DylanDylann commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

Uh oh!

linhvovan29546 commented Mar 7, 2025 •

edited

Loading

DylanDylann commented Mar 7, 2025 •

edited

Loading

DylanDylann commented Mar 7, 2025 •

edited

Loading

linhvovan29546 commented Mar 7, 2025 •

edited

Loading

DylanDylann commented Mar 7, 2025 •

edited

Loading