Skip to content

Prevent tappable bank account in EnableStep #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2021
Merged

Prevent tappable bank account in EnableStep #5796

merged 5 commits into from
Oct 13, 2021

Conversation

marcaaron
Copy link
Contributor

Details

We need the UI from MenuItem but it should not be tappable. This enables us to reuse this view for display purposes only by adding an interactive state to the various styles.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180913

Tests

  1. Add a VBA and get all the way to the validation step
  2. Verify that the bank account UI shown here is not clickable or interactive in any way
    2021-10-12_14-49-34

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner October 13, 2021 00:55
@marcaaron marcaaron self-assigned this Oct 13, 2021
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team October 13, 2021 00:55
@trjExpensify
Copy link
Contributor

Should we CP this bad boy when it's through review?

@marcaaron
Copy link
Contributor Author

Sure.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron requested a review from a team October 13, 2021 19:48
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team October 13, 2021 19:49
@marcaaron marcaaron removed the request for review from jasperhuangg October 13, 2021 19:50
@stitesExpensify stitesExpensify merged commit 7b82f4d into main Oct 13, 2021
@stitesExpensify stitesExpensify deleted the marcaaron-preventTappableBankAccount branch October 13, 2021 20:33
github-actions bot pushed a commit that referenced this pull request Oct 13, 2021
@stitesExpensify
Merge pull request #5796 from Expensify/marcaaron-preventTappableBank…
d1d4b9f 
…Account

Prevent tappable bank account in EnableStep

(cherry picked from commit 7b82f4d)
This was referenced Oct 13, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @stitesExpensify in version: 1.1.7-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcaaron @trjExpensify @OSBotify @stitesExpensify