-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update Using-Reports-in-New-Expensify.md #57906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm adding two images to this help doc to help users understand how Reports works.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@thesahindia @kadiealexander One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://3cb545d2.helpdot.pages.dev ⚡️ |
@kadiealexander and @deetergp - this one is on hold until these image PRs are approved: 🚨 Heads up! 🚨 I’ll be offline until Wednesday, March 12, 2025, and won’t be actively monitoring this GitHub during that time. |
Oh, my bad. Just FYI @kadiealexander @alexpensify we generally add |
New PR: #58068 |
🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.11-1 🚀
|
That's my bad, Scott; I was rushing to get this PR ready before going on vacation. 🤦🏼♂️ |
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀
|
I'm adding two images to this help doc to help users understand how Reports works.
Explanation of Change
Fixed Issues
$https://github.com/Expensify/Expensify/issues/438253
PROPOSAL:
Tests
Offline tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined