fix: Track seen logins to filter out duplicates in personal details #57459

danstepanov · 2025-02-26T09:38:52Z

Explanation of Change

Optimized the filtering of personal details in mention suggestions by using a Set to track duplicate logins instead of using array.findIndex. This visibly improves performance and fixes flickering issues when typing @ in the composer, particularly noticeable with large numbers of personal details. This issue only pertains to iOS.

Fixed Issues

$ #54991
PROPOSAL: #54991 (comment)

Tests

Authenticate with the Applause test account
Open any chat or room with multiple participants (preferably a workspace with many members)
Type @ in the composer
Verify the mention suggestions menu appears smoothly without flickering and in a timely fashion
Type additional characters to filter the suggestions
Verify the menu updates smoothly without flickering or lag
Select a suggestion and verify it's inserted correctly
Verify that duplicate logins are still properly filtered out

Verify that no errors appear in the JS console

Offline tests

No offline testing needed as this is a UI performance optimization.

QA Steps

Sam as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Before
https://github.com/user-attachments/assets/741eef7a-504d-4cae-8c6c-382df043d6da

After
https://github.com/user-attachments/assets/bf633fc7-f211-4686-9852-9640ae10f47e

Android: mWeb Chrome

Before
https://github.com/user-attachments/assets/741eef7a-504d-4cae-8c6c-382df043d6da

After
https://github.com/user-attachments/assets/bf633fc7-f211-4686-9852-9640ae10f47e

iOS: Native

Before
https://github.com/user-attachments/assets/741eef7a-504d-4cae-8c6c-382df043d6da

After
https://github.com/user-attachments/assets/bf633fc7-f211-4686-9852-9640ae10f47e

iOS: mWeb Safari

Before
https://github.com/user-attachments/assets/741eef7a-504d-4cae-8c6c-382df043d6da

After
https://github.com/user-attachments/assets/bf633fc7-f211-4686-9852-9640ae10f47e

MacOS: Chrome / Safari

Before
https://github.com/user-attachments/assets/741eef7a-504d-4cae-8c6c-382df043d6da

After
https://github.com/user-attachments/assets/bf633fc7-f211-4686-9852-9640ae10f47e

MacOS: Desktop

Before
https://github.com/user-attachments/assets/741eef7a-504d-4cae-8c6c-382df043d6da

After
https://github.com/user-attachments/assets/bf633fc7-f211-4686-9852-9640ae10f47e

github-actions · 2025-02-26T09:39:08Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

melvin-bot · 2025-02-27T08:20:18Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-02-27T13:00:02Z

@danstepanov please follow the steps here to sign the CLA

danstepanov · 2025-02-28T04:11:51Z

I have read the CLA Document and I hereby sign the CLA

danstepanov · 2025-02-28T04:16:58Z

@abdulrahuman5196 do you have time to add the requisite videos (presumably just android native?). I am currently busy with other tasks.

… introduced by (Expensify#54805)

… to handle JSX syntax via the react-jsx compiler option

danstepanov · 2025-02-28T05:44:38Z

I have some additional changes I'd like to make to this that would further improve performance but, in the interest of moving onto other tasks, this does solve the problem.

hannojg · 2025-02-28T08:02:43Z

Thats sounds good, we usually create a follow up issue ticket for that!
(let me create one …)

mrousavy · 2025-02-28T10:35:16Z

tsconfig.json

@@ -22,7 +22,8 @@
            "@styles/*": ["./src/styles/*"],
            "@src/*": ["./src/*"],
            "@userActions/*": ["./src/libs/actions/*"]
-        }
+        },
+        "jsx": "react-jsx"


what does this exactly do?

not sure why I didn't get these notifications but I made this change for reasons unrelated directly to this PR, I can remove it. I was running into Typescript issues while working on the issue and this seemed to resolve them. This has to do with how JSX is transformed in TS files.

mountiny · 2025-03-02T23:16:17Z

tsconfig.json

@@ -22,7 +22,8 @@
            "@styles/*": ["./src/styles/*"],
            "@src/*": ["./src/*"],
            "@userActions/*": ["./src/libs/actions/*"]
-        }
+        },
+        "jsx": "react-jsx"


This change seems unrelated to this pr, can you please remove it?

lakchote · 2025-03-03T06:22:11Z

tsconfig.json

@@ -22,7 +22,8 @@
            "@styles/*": ["./src/styles/*"],
            "@src/*": ["./src/*"],
            "@userActions/*": ["./src/libs/actions/*"]
-        }
+        },
+        "jsx": "react-jsx"


This shouldn't be needed here. Please remove it as said above ^

@danstepanov Bump on this one

sorry for the delay here, I'm just seeing these messages. I've removed the change.

lakchote · 2025-03-03T06:29:18Z

Assigning @DylanDylann, see https://expensify.slack.com/archives/C02NK2DQWUX/p1740983291502619?thread_ts=1740957422.190539&cid=C02NK2DQWUX

DylanDylann · 2025-03-03T06:41:59Z

Thanks. I will start on this today

DylanDylann · 2025-03-03T09:31:40Z

One redundant change, the rest looks fine.

DylanDylann · 2025-03-03T09:56:13Z

@danstepanov Ops.... While testing on some chats, I see that this problem still happens on IOS

Screen.Recording.2025-03-03.at.16.55.10.mov

DylanDylann · 2025-03-03T10:10:24Z

From my investigation, the suggestion list doesn't display because of this check

App/src/components/AutoCompleteSuggestions/index.tsx

Lines 142 to 144 in 9b85822

    
           if ((containerState.width === 0 && containerState.left === 0 && containerState.bottom === 0) || (containerState.cursorCoordinates.x === 0 && containerState.cursorCoordinates.y === 0)) { 
        
               return null; 
        
           }

From my log, I see that:

cursorCoordinates {"x": 0, "y": 0}

Co-authored-by: DylanDylann <[email protected]>

…y fallback values, remove irrelevant comment

DylanDylann · 2025-03-07T11:22:11Z

@danstepanov I think we also need to revert these changes

DylanDylann · 2025-03-07T11:22:58Z

src/components/AutoCompleteSuggestions/index.tsx

            });
        });
    }, [measureParentContainerAndReportCursor, windowHeight, windowWidth, keyboardHeight, shouldUseNarrowLayout, suggestionsLength, bottomInset, topInset, isKeyboardAnimatingRef]);

-    if ((containerState.width === 0 && containerState.left === 0 && containerState.bottom === 0) || (containerState.cursorCoordinates.x === 0 && containerState.cursorCoordinates.y === 0)) {
+    // Only prevent rendering if we have no suggestions


This comment doesn't reflect all below conditions

…s to isEnoughSpaceToRenderMenuAboveForSmall

…ng the AutoCompleteSuggestionsPortal

DylanDylann · 2025-03-11T09:31:58Z

src/components/AutoCompleteSuggestions/index.tsx

@@ -134,14 +146,16 @@ function AutoCompleteSuggestions<TSuggestion>({measureParentContainerAndReportCu
                left: leftValue.current,
                bottom: bottomValue,
                width: widthValue,
-                cursorCoordinates,
+                cursorCoordinates: {x: cursorCoordinates.x, y: cursorCoordinates.y},


@danstepanov One more place, please revert it

DylanDylann · 2025-03-11T09:37:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-11.at.16.58.36.mov

Android: mWeb Chrome

Screen.Recording.2025-03-11.at.17.01.15.mov

iOS: Native

Screen.Recording.2025-03-11.at.16.59.17.mov

iOS: mWeb Safari

Screen.Recording.2025-03-11.at.17.00.17.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-11.at.17.02.38.mov

MacOS: Desktop

Screen.Recording.2025-03-11.at.17.01.58.mov

src/components/AutoCompleteSuggestions/index.tsx

DylanDylann · 2025-03-11T16:14:03Z

@lakchote Minor suggested change here. All rest looks fine to me

lakchote

@danstepanov please address comment here to make things consistent. Other than that LGTM

Co-authored-by: DylanDylann <[email protected]>

lakchote

LGTM. @mountiny if you want to check it

Addressed

mountiny · 2025-03-14T00:15:35Z

All good, not reviewing but going to merge as you approved

OSBotify · 2025-03-14T00:28:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-14T02:17:31Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

kavimuru · 2025-03-14T17:46:05Z

Failing with original bug iD #54991 in android and iOS

https://platform.applause.com/services/links/v1/external/d9e395930e859695b69d33bb414f82ea7b14918cdd498acfbb75423062f7a4a5
https://platform.applause.com/services/links/v1/external/aa5789f55ed9c88ff1ff98ca0fdeee38ef13309351410d72a77905afb6aad71a

mountiny · 2025-03-14T18:48:41Z

@danstepanov @DylanDylann Can you please follow up, seems like its not fixed thanks!

DylanDylann · 2025-03-17T03:48:12Z

@kavimuru This appears to be inconsistent across accounts. If possible, could you export your Onyx data? That way, we can take a deeper look into it and assist you further.

github-actions · 2025-03-17T11:39:59Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

danstepanov marked this pull request as ready for review February 27, 2025 08:20

danstepanov requested a review from a team as a code owner February 27, 2025 08:20

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team February 27, 2025 08:20

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 28, 2025

@danstepanov has signed the CLA in Expensify/App#57459

3e7f30e

danstepanov added 3 commits February 27, 2025 21:12

Track seen logins to filter out duplicates in personal details, issue…

502db8e

… introduced by (Expensify#54805)

fix namespace import issues in SuggestionMention

7f13e33

fix remaining linter error for SuggestionMention, tell TypeScript how…

6e93955

… to handle JSX syntax via the react-jsx compiler option

danstepanov force-pushed the @danstepanov/fix/slow-response-mention-suggestion branch from 437fed3 to 6e93955 Compare February 28, 2025 05:13

Trigger CI build

da39f89

danstepanov force-pushed the @danstepanov/fix/slow-response-mention-suggestion branch from 1d10e3c to da39f89 Compare February 28, 2025 05:39

hannojg approved these changes Feb 28, 2025

View reviewed changes

mrousavy reviewed Feb 28, 2025

View reviewed changes

mountiny previously requested changes Mar 2, 2025

View reviewed changes

mountiny assigned danstepanov Mar 2, 2025

lakchote reviewed Mar 3, 2025

View reviewed changes

lakchote requested review from DylanDylann and removed request for abdulrahuman5196 March 3, 2025 06:28

danstepanov and others added 2 commits March 7, 2025 01:50

add back container cursor validation check

6ad3297

Co-authored-by: DylanDylann <[email protected]>

remove unnecessary variables for cursorCoordinates, remove unnecessar…

0c00b31

…y fallback values, remove irrelevant comment

danstepanov force-pushed the @danstepanov/fix/slow-response-mention-suggestion branch from 8f38734 to 0c00b31 Compare March 7, 2025 10:17

DylanDylann reviewed Mar 7, 2025

View reviewed changes

danstepanov added 2 commits March 10, 2025 23:48

revert changes to isEnoughSpaceToRenderMenuAboveForBig, revert change…

7a7dc32

…s to isEnoughSpaceToRenderMenuAboveForSmall

expand upon comment above conditional statement that prevents renderi…

e6c8e16

…ng the AutoCompleteSuggestionsPortal

DylanDylann reviewed Mar 11, 2025

View reviewed changes

src/components/AutoCompleteSuggestions/index.tsx Outdated Show resolved Hide resolved

DylanDylann approved these changes Mar 11, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote March 11, 2025 16:13

lakchote reviewed Mar 12, 2025

View reviewed changes

Update src/components/AutoCompleteSuggestions/index.tsx

1f149b4

Co-authored-by: DylanDylann <[email protected]>

DylanDylann approved these changes Mar 13, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote March 13, 2025 02:48

danstepanov requested a review from mountiny March 13, 2025 05:08

lakchote approved these changes Mar 13, 2025

View reviewed changes

mountiny merged commit bd8809d into Expensify:main Mar 14, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 14, 2025

Deploy Checklist: New Expensify 2025-03-14 #58424

Closed

90 tasks

melvin-bot bot mentioned this pull request Mar 17, 2025

[$250] [AWAITING CHECKLIST][Due for payment 2025-03-24] iOS - Chat - The mention suggestion list is slow to respond #54991

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Track seen logins to filter out duplicates in personal details #57459

fix: Track seen logins to filter out duplicates in personal details #57459

danstepanov commented Feb 26, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

melvin-bot bot commented Feb 27, 2025

luacmartins commented Feb 27, 2025

danstepanov commented Feb 28, 2025

danstepanov commented Feb 28, 2025

danstepanov commented Feb 28, 2025

hannojg commented Feb 28, 2025 •

edited

Loading

mrousavy Feb 28, 2025

danstepanov Mar 6, 2025

mountiny Mar 2, 2025

lakchote Mar 3, 2025

DylanDylann Mar 3, 2025

danstepanov Mar 6, 2025

lakchote commented Mar 3, 2025

DylanDylann commented Mar 3, 2025

DylanDylann commented Mar 3, 2025

DylanDylann commented Mar 3, 2025

DylanDylann commented Mar 3, 2025 •

edited

Loading

DylanDylann commented Mar 7, 2025

DylanDylann Mar 7, 2025

DylanDylann Mar 11, 2025

DylanDylann commented Mar 11, 2025 •

edited

Loading

DylanDylann commented Mar 11, 2025

lakchote left a comment

lakchote left a comment

mountiny commented Mar 14, 2025

OSBotify commented Mar 14, 2025

github-actions bot commented Mar 14, 2025

kavimuru commented Mar 14, 2025

mountiny commented Mar 14, 2025

DylanDylann commented Mar 17, 2025

github-actions bot commented Mar 17, 2025

fix: Track seen logins to filter out duplicates in personal details #57459

fix: Track seen logins to filter out duplicates in personal details #57459

Conversation

danstepanov commented Feb 26, 2025 • edited by github-actions bot Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Feb 26, 2025 • edited Loading

melvin-bot bot commented Feb 27, 2025

luacmartins commented Feb 27, 2025

danstepanov commented Feb 28, 2025

danstepanov commented Feb 28, 2025

danstepanov commented Feb 28, 2025

hannojg commented Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lakchote commented Mar 3, 2025

DylanDylann commented Mar 3, 2025

DylanDylann commented Mar 3, 2025

DylanDylann commented Mar 3, 2025

DylanDylann commented Mar 3, 2025 • edited Loading

DylanDylann commented Mar 7, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented Mar 11, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Mar 11, 2025

lakchote left a comment

Choose a reason for hiding this comment

lakchote left a comment

Choose a reason for hiding this comment

mountiny commented Mar 14, 2025

OSBotify commented Mar 14, 2025

github-actions bot commented Mar 14, 2025

kavimuru commented Mar 14, 2025

mountiny commented Mar 14, 2025

DylanDylann commented Mar 17, 2025

github-actions bot commented Mar 17, 2025

danstepanov commented Feb 26, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

hannojg commented Feb 28, 2025 •

edited

Loading

DylanDylann commented Mar 3, 2025 •

edited

Loading

DylanDylann commented Mar 11, 2025 •

edited

Loading