Fix session expired errors right after login #57420

VickyStash · 2025-02-25T18:05:23Z

Explanation of Change

Fix session expired errors right after login for the new users, is the user was re-navigated from OD to ND.

Fixed Issues

$ #57083
PROPOSAL: #57083 (comment)

Tests

Verify that no errors appear in the JS console

WEB:

Pre-steps:
Use one browser window and make sure you’re signed-out of any account on New Dot and Old Dot.

Steps:

Login with a new account in the ND.
Close the ND window when the onboarding modal is shown.
Open the OD and login with the account from the step 1.
Enter the magic code and continue login. Since you are testing over prod OD, the URL will turn into https://new.expensify.com/transition?... for transition, you need to copy it quickly and modify to navigate to DEV URL, ex https://dev.new.expensify.com:8082/transition?...
Make sure that after opening ND with the transition link https://dev.new.expensify.com:8082/transition?... the user stays logged in, the app re-authenticated with the shortLivedAuthToken.

Note: don't reuse one transition link several times.

Mobile platforms (Hybrid App):

Login to the app.
Go to Setting page.
Tap Switch to Expensify classic. Make sure transition works as expected.
In the OD oped side bar.
Tap Try New Expensify. Make sure transition works as expected.

Desktop:

Create a new account.
Go through onboarding flow.
Make sure it works as expected.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

WEB:

Pre-steps:
Use one browser window and make sure you’re signed-out of any account on New Dot and Old Dot.

Steps:

Login with a new account in the ND.
Close the ND window when the onboarding modal is shown.
Open the OD and login with the account from the step 1.
Enter the magic code and continue login.
Make sure that the user stays logged in after the transition to the ND.

Mobile platforms (Hybrid App):

Login to the app.
Go to Setting page.
Tap Switch to Expensify classic. Make sure transition works as expected.
In the OD oped side bar.
Tap Try New Expensify. Make sure transition works as expected.

Desktop:

Create a new account.
Go through onboarding flow.
Make sure it works as expected.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

mountiny · 2025-03-02T23:32:07Z

@VickyStash please feel free to make this ready for a review

…xpired-after-login

melvin-bot · 2025-03-03T14:35:09Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-03-03T22:07:43Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-03-03T22:08:11Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

mountiny · 2025-03-03T22:23:14Z

@dominictb kicked off some builds to make it easier for you hopefully

github-actions · 2025-03-03T22:39:21Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57420/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57420/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

dominictb · 2025-03-04T08:21:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-04.at.15.12.57.mov

Android: mWeb Chrome

Screen.Recording.2025-03-04.at.15.05.51.mov

iOS: Native

Screen.Recording.2025-03-04.at.15.02.45.mov

iOS: mWeb Safari

Screen.Recording.2025-03-04.at.15.08.37.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-04.at.14.52.14.mov

MacOS: Desktop

Screen.Recording.2025-03-04.at.15.14.13.mov

mountiny

Thank you! lets give it a go

OSBotify · 2025-03-05T23:35:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-06T23:15:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-10T21:10:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Fix user being logged out right after login through OD

2ec1a94

VickyStash changed the title ~~Fix session expired errors right after login~~ [WIP] Fix session expired errors right after login Feb 25, 2025

VickyStash mentioned this pull request Feb 25, 2025

[Due for payment 2025-03-17] [$250] Session expired errors right after login #57083

Closed

8 tasks

mountiny requested a review from dominictb March 2, 2025 23:31

mountiny assigned VickyStash Mar 2, 2025

VickyStash added 5 commits March 3, 2025 12:23

Merge branch 'refs/heads/main' into VickyStash/bugfix/57083-session-e…

28c0b95

…xpired-after-login

Fix TS errors

c75bda2

Lint fixes

d247663

Fix misspell, clean up

a71d52f

Simplify logic

9d6c29b

VickyStash changed the title ~~[WIP] Fix session expired errors right after login~~ Fix session expired errors right after login Mar 3, 2025

VickyStash marked this pull request as ready for review March 3, 2025 14:35

VickyStash requested a review from a team as a code owner March 3, 2025 14:35

melvin-bot bot requested review from mountiny and removed request for a team March 3, 2025 14:35

mountiny added the Ready To Build label Mar 3, 2025

This comment has been minimized.

Sign in to view

dominictb approved these changes Mar 4, 2025

View reviewed changes

VickyStash mentioned this pull request Mar 5, 2025

[hold for payment 2025-03-25] [$500][CRITICAL] Onboarding - NewDot is infinite loading and onboarding model doesn't display #57689

Closed

8 tasks

mountiny approved these changes Mar 5, 2025

View reviewed changes

mountiny merged commit 739cb4f into Expensify:main Mar 5, 2025
18 of 22 checks passed

github-actions bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks

NJ-2020 mentioned this pull request Mar 17, 2025

[Due for payment 2025-04-16] [$500] [CRITICAL] Infinite Spinners & "Hmm... It's Not Here" Errors for on NewDot #58384

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix session expired errors right after login #57420

Fix session expired errors right after login #57420

Uh oh!

VickyStash commented Feb 25, 2025 •

edited

Loading

Uh oh!

mountiny commented Mar 2, 2025

Uh oh!

melvin-bot bot commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

mountiny commented Mar 3, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 3, 2025

Uh oh!

dominictb commented Mar 4, 2025

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

Uh oh!

Fix session expired errors right after login #57420

Fix session expired errors right after login #57420

Uh oh!

Conversation

VickyStash commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mountiny commented Mar 2, 2025

Uh oh!

melvin-bot bot commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

mountiny commented Mar 3, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 3, 2025

Uh oh!

dominictb commented Mar 4, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

Uh oh!

VickyStash commented Feb 25, 2025 •

edited

Loading