-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: 'Add approval' can be disabled even when 'Smart limit' are enabled #57006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@nkdengineer Did you confirm the translation? |
@dominictb asking here |
@nkdengineer Seems like the translations are confirmed on Slack, code changes look good. But I need the final confirmation from @Expensify/design ![]() Is it fine? |
I think I prefer this option. This feels more in line with how we handle this type of thing in other cases. |
While Option 1 follows the patterns we have for regular toggle rows more closely, Option 2 is more in line with the other toggle rows on the More Features page (bold title, contained in a card, etc). So I'd say go with Option 2. @Expensify/design for the gut check. Also, can we check the line-height we're using for these descriptions? The bottom two look tight and when I inspect I'm seeing a 16px line-height. They should have 20px line-height like the top one. |
Interesting, I thought that if we were using the label font size (13px) that we should be using 16px line height? |
In that screenshot above Danny, what are the font sizes? I think our hint text for toggles normally uses 13px font size (label) and thus I would expect it to use 16px line height. But if that text in your screenshot is 15px... then 20px line height makes sense. |
@shawnborton These don't use our standard toggle rows. Because they act as titles/headers for the cards, we bumped everything up. Here's a comparison: And then here's a comparison of Workflows page using the current, custom toggle rows and our standard rows. Hopefully this is helpful! 😅 |
Okay cool - so then 20px line height is the way to go here :) |
Great investigation! 20px sounds good to me 👍 |
@dominictb i updated, please check again |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeScreen.Recording.2025-02-26.at.23.56.03.moviOS: mWeb SafariScreen.Recording.2025-02-26.at.23.54.50.movMacOS: Chrome / Safariweb.mp4 |
Thank you @nkdengineer |
@mountiny i updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.10-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀
|
Explanation of Change
Fixed Issues
$ #56187
PROPOSAL: #56187 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov