Skip to content

Clear errorForm upon change to field #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Clear errorForm upon change to field #5668

merged 1 commit into from
Oct 6, 2021

Conversation

ctkochan22
Copy link
Contributor

@Expensify/pullerbear
cc @tgolen

Details

Fixed Issues

$ #5389

Tests / QA Steps

  1. Go to the login form
  2. type in an invalid email, click continue to display error
  3. Change your input, and verify that the error message is no longer there.
  4. Change it to another invalid email and click continue. Verify that error message comes up again
  5. Now add a valid user email, and log in. Verify you can successfully log in for regression testing

w4a5VO6Vjn

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@ctkochan22 ctkochan22 requested a review from a team October 6, 2021 05:18
@ctkochan22 ctkochan22 self-assigned this Oct 6, 2021
@MelvinBot MelvinBot requested review from Gonals and removed request for a team October 6, 2021 05:19
@Gonals Gonals merged commit 04083b1 into main Oct 6, 2021
@Gonals Gonals deleted the ckt_login_errorForm branch October 6, 2021 07:39
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @Gonals in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants