Prevent autofocus/refocus on small screen on the report page #56396

bernhardoj · 2025-02-05T06:34:48Z

Explanation of Change

Fixed Issues

$ #55485
PROPOSAL: #55485 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace chat with unsettled expense

Open the expense thread chat
Verify the composer is (web/desktop) focused / (iOS, Android, mWeb) not focused
Edit anything from the money request
Verify the composer is (web/desktop) focused / (iOS, Android, mWeb) not focused
Go back
Verify the composer is (web/desktop) focused / (iOS, Android, mWeb) not focused

NOTE: This PR changes the autofocus behavior of composer. Mobile screen won't have autofocus anymore.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-02-05T06:34:53Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2025-02-06T10:20:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2025-02-07T12:08:47Z

@bernhardoj, can we please update the QA step and add a note that after this PR, we are updating all cases where the composer for mobile devices should not be auto-focused? I believe some TestRail tests expect the input to auto-focus on mobile devices, which may lead to deployment blockers.

jayeshmangwani

LGTM 🚀

bernhardoj · 2025-02-07T16:12:28Z

Done.

Btw, can we hold until #56358 is solved? That issue is only reproducible when the composer is refocused after sending a password-protected PDF. This PR hasn't fixed the refocus behavior when sending attachment yet. After that issue is fixed, I'll try to fix the refocus behavior after sending an attachment.

bernhardoj · 2025-02-12T10:17:28Z

While waiting for the other PR, I tried to find the root cause of why the composer was focused after sending an attachment. This is because we focus on the composer every time the app comes from the background.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 741 to 748 in 5ddef34

    
           const appStateSubscription = AppState.addEventListener('change', (nextAppState) => { 
        
               if (!nextAppState.match(/inactive|background/)) { 
        
                   focus(true); 
        
                   return; 
        
               } 
        
               Keyboard.dismiss(); 
        
           });

In our case, when selecting an attachment, the app goes to the background, and when we back to the app, the app goes to the foreground (active) again.

Do we want to keep this behavior?

android.mp4

jayeshmangwani · 2025-02-13T15:52:11Z

Do we want to keep this behavior?

IMHO, composer shouldn't be the focus, but I'll defer to @shawnborton and @marcochavezf.

jayeshmangwani · 2025-02-13T15:53:05Z

While waiting for the other PR

Thanks for the update! I'll re-review this PR once the other PR is merged.

shawnborton · 2025-02-13T16:04:08Z

Agree, we shouldn't auto focus for the user there.

marcochavezf · 2025-02-17T17:11:01Z

While waiting for the other PR

Thanks for the update! I'll re-review this PR once the other PR is merged.

👋🏽 This is the PR we're waiting for, right?

jayeshmangwani · 2025-02-17T18:16:31Z

👋🏽 This is the #56748 we're waiting for, right?

Yes, correct

bernhardoj · 2025-02-18T03:25:58Z

I've bumped the other PR for review.

marcochavezf · 2025-02-19T14:26:53Z

#56748 has been merged 🎉

jayeshmangwani · 2025-02-20T05:37:54Z

@bernhardoj please merge main and resolve the conflicts. Since other PR has been merged, we can retest this PR and proceed with the merge.

bernhardoj · 2025-02-20T10:22:50Z

@jayeshmangwani done

marcochavezf

LGTM, thanks guys!

OSBotify · 2025-02-20T15:10:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-20T22:19:00Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.1.3-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-21T22:51:36Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.3-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

bernhardoj added 2 commits February 5, 2025 13:36

prevent autofocus/refocus on mobile screen

eaa7c67

Merge branch 'main' into fix/55485-prevent-autofocus-on-small-screen

5c8fca8

bernhardoj requested a review from a team as a code owner February 5, 2025 06:34

melvin-bot bot requested a review from jayeshmangwani February 5, 2025 06:34

melvin-bot bot removed the request for review from a team February 5, 2025 06:34

bernhardoj added 3 commits February 5, 2025 14:35

update comment

255a075

lint

20bc595

lint

de7c300

jayeshmangwani approved these changes Feb 7, 2025

View reviewed changes

melvin-bot bot requested a review from marcochavezf February 7, 2025 12:08

bernhardoj mentioned this pull request Feb 12, 2025

Fix keyboard overlaps composer after coming back from send password protected PDF attachment page #56748

Merged

50 tasks

Merge branch 'main' into fix/55485-prevent-autofocus-on-small-screen

28d78e8

remove unnecessary condition

9ae7d3f

chrispader mentioned this pull request Feb 17, 2025

fix: Prevent keyboard from opening when navigating back to ReportScreen #56278

Closed

50 tasks

don't refocus after coming from bg

0bb53b4

Merge branch 'main' into fix/55485-prevent-autofocus-on-small-screen

4e8007c

marcochavezf approved these changes Feb 20, 2025

View reviewed changes

marcochavezf merged commit 6c4624b into Expensify:main Feb 20, 2025
16 checks passed

github-actions bot mentioned this pull request Feb 20, 2025

Deploy Checklist: New Expensify 2025-02-20 #57207

Closed

36 tasks

melvin-bot bot mentioned this pull request Feb 21, 2025

[Due for payment 2025-02-28] [$250] Keyboard opens with composer autofocused when modifying an expense and go back to the report #55485

Closed

8 tasks

FitseTLT mentioned this pull request Mar 24, 2025

[$250] Thread - The compose box is not focused after starting a thread #58874

Closed

8 tasks

Prevent autofocus/refocus on small screen on the report page #56396

Prevent autofocus/refocus on small screen on the report page #56396

Uh oh!

Conversation

bernhardoj commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 5, 2025

Uh oh!

jayeshmangwani commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Feb 7, 2025

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Feb 7, 2025

Uh oh!

bernhardoj commented Feb 12, 2025

Uh oh!

jayeshmangwani commented Feb 13, 2025

Uh oh!

jayeshmangwani commented Feb 13, 2025

Uh oh!

shawnborton commented Feb 13, 2025

Uh oh!

marcochavezf commented Feb 17, 2025

Uh oh!

jayeshmangwani commented Feb 17, 2025

Uh oh!

bernhardoj commented Feb 18, 2025

Uh oh!

marcochavezf commented Feb 19, 2025

Uh oh!

jayeshmangwani commented Feb 20, 2025

Uh oh!

bernhardoj commented Feb 20, 2025

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Uh oh!

bernhardoj commented Feb 5, 2025 •

edited

Loading

jayeshmangwani commented Feb 6, 2025 •

edited

Loading