refactor: Make AttachmentModal actual screens on native platforms

[chrispader]

@mountiny

Explanation of Change

In this issue i pointed out that we want to migrate the AttachmentModal to a (modal) screen. After some more research, this actually wasn't accurate, because we'd rather want to change this into an actual screen on native platforms, while keeping the "modal-like" appearance on web.

This is what i did in this PR. This is not the foundational PR for the modal screen migration yet.

This PR migrates all usages of the AttachmentModal component to use a central AttachmentModalScreen instead. The screen handles the different appearance on web vs. native. For each of the different modal types ("report attachment", "profile avatar", "workspace avatar", ...) there is a specific content component.

All common code is handled in the BaseContent component, while all platform-specific code is in the relevant AttachmentModalWrapper, e.g. modal code on web vs. ScreenWrapper on native.

Fixed Issues

$ #53493
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Go to all flows that show attachments and and check if

• on web the attachment is visible in the "overlay"-style modal,
• on native platforms, there is a regular screen animation with the attachment on a new screen.

Following flows to test:

• Report attachment: Open an image/attachment from a chat
• Workspace avatar: Open the workspace avatar image
• Profile avatar: Open the profile avatar image
• Transaction Receipt: Open the receipt of a transaction
• Send attachment: Upload a new attachment to the chat and check if the preview works

Offline tests

Not needed.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen_Recording_20250207_004027_New.Expensify.Dev.mp4

Screen_Recording_20250207_004044_New.Expensify.Dev.mp4

Screen_Recording_20250207_003937_New.Expensify.Dev.mp4

Screen_Recording_20250207_004006_New.Expensify.Dev.2.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.32.44.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.32.30.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-03.at.11.26.24.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.32.17.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.33.13.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-02-06.at.16.38.14.mov

Screen.Recording.2025-02-06.at.16.37.58.mov

Screen.Recording.2025-02-06.at.16.37.32.mov

Screen.Recording.2025-02-06.at.16.37.47.mov

Screen.Recording.2025-02-06.at.16.36.50.mov

MacOS: Desktop

[chrispader]

@parasharrajat the PR is not quite ready yet. I will let you know once it's done. Actively working on it.

Updating all usages of AttachmentModal to screens is more complex than i thought.

[chrispader]

@parasharrajat i'll merge main again today. Could you take a look at this in the next days? The PR is ready from my side :)

[parasharrajat]

Sure. All important tasks are done I can start running test runs now. ETA is Thursday as I will be travelling tomorrow.

[mountiny]

some checks are failing, how is this looking?

[chrispader]

some checks are failing, how is this looking?

fixed all checks. Ready for final review 🙌🏼

cc @parasharrajat

[chrispader]

@mountiny There's one remaining Changed ESLint check issue around a deprecated type from react-native-gesture-handler but i think this should be handled in a separate PR, as there are also changes to other files needed

[CortneyOfstad]

Hey team! Just checking to see where we're at with this — thanks!

[chrispader]

Still waiting for review by @parasharrajat 🙌🏼

[parasharrajat]

I will start posting feedback in 2 hours. Thanks for the ping.

[parasharrajat]

Testing...

[chrispader]

@parasharrajat updated the PR again with main. Could you please give this a look next week? Thanks 🙌🏼

[chrispader]

@parasharrajat i'll merge main again to fix conflicts. Could you please review this this week? 🙌🏼

[parasharrajat]

Testing...

[github-actions]

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56219-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56219-hybrid/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56219/NewExpensify.dmg	https://56219.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀