Skip to content

[No QA] 50360 - Follow up to fix eslint errors #55566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[No QA] 50360 - Follow up to fix eslint errors #55566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/libs/actions/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import type {Icon} from '@src/types/onyx/OnyxCommon';
import type {ReportActions} from '@src/types/onyx/ReportAction';
import type ReportAction from '@src/types/onyx/ReportAction';
import {isEmptyObject} from '@src/types/utils/EmptyObject';
import * as Report from './Report';
import {getMostRecentReportID, navigateToConciergeChatAndDeleteReport, notifyNewAction} from './Report';

type OptimisticReport = Pick<OnyxTypes.Report, 'reportName' | 'managerID' | 'pendingFields' | 'participants'>;
type Assignee = {
Expand Down Expand Up @@ -335,7 +335,7 @@ function createTaskAndNavigate(
clearOutTaskInfo();
Navigation.dismissModal(parentReportID);
}
Report.notifyNewAction(parentReportID, currentUserAccountID);
notifyNewAction(parentReportID, currentUserAccountID);
}

/**
Expand Down Expand Up @@ -1014,7 +1014,7 @@ function getNavigationUrlOnTaskDelete(report: OnyxEntry<OnyxTypes.Report>): stri
}

// If no parent report, try to navigate to most recent report
const mostRecentReportID = Report.getMostRecentReportID(report);
const mostRecentReportID = getMostRecentReportID(report);
if (mostRecentReportID) {
return ROUTES.REPORT_WITH_ID.getRoute(mostRecentReportID);
}
Expand Down Expand Up @@ -1162,7 +1162,7 @@ function deleteTask(report: OnyxEntry<OnyxTypes.Report>) {
};

API.write(WRITE_COMMANDS.CANCEL_TASK, parameters, {optimisticData, successData, failureData});
Report.notifyNewAction(report.reportID, currentUserAccountID);
notifyNewAction(report.reportID, currentUserAccountID);

const urlToNavigateBack = getNavigationUrlOnTaskDelete(report);
if (urlToNavigateBack) {
Expand Down Expand Up @@ -1258,7 +1258,7 @@ function clearTaskErrors(reportID: string) {
if (report?.pendingFields?.createChat === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) {
Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`, report.parentReportActionID ? {[report.parentReportActionID]: null} : {});

Report.navigateToConciergeChatAndDeleteReport(reportID);
navigateToConciergeChatAndDeleteReport(reportID);
return;
}

Expand Down
Loading