Draft report not showing in the draft status filter #55544

ishakakkad · 2025-01-21T16:56:13Z

Explanation of Change

Fixed Issues

$#55235
PROPOSAL: #55235 (comment)

Tests

Verify that no errors appear in the JS console

Same as QA

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Create an open report in OldDot
Create Draft Report.
Go to the Reports page in NewDot
You should have more than 50 expenses inside "All Expense Report".
Scroll down to end of the page so new API request called 2nd page records.
Click the Drafts status filter
Expected: Draft report should display in draft report page.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Web.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

IOS.Web.mov

MacOS: Chrome / Safari

Web.mov

Web Small Screen.

Web.Mobile.mov

MacOS: Desktop

Desktop.mov

github-actions · 2025-01-21T16:56:25Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

melvin-bot · 2025-01-21T22:00:35Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-01-21T22:06:26Z

@ishakakkad can you please follow these steps for the CLA?

luacmartins · 2025-01-21T22:06:55Z

@hungvu193 let's prioritize reviewing this PR since it's a big issue affecting multiple users

ishakakkad · 2025-01-21T22:11:00Z

I have read the CLA Document and I hereby sign the CLA

ishakakkad · 2025-01-21T22:12:07Z

@luacmartins I have fixed prettier issue, can you please approve workflows again?

luacmartins · 2025-01-21T22:14:19Z

done

ishakakkad · 2025-01-21T22:21:47Z

@luacmartins sorry can you approve one more time, eslint issues fixed.

…t-showing

hungvu193 · 2025-01-22T00:03:14Z

@hungvu193 let's prioritize reviewing this PR since it's a big issue affecting multiple users

Sure. I'll review it today

hungvu193 · 2025-01-22T09:26:26Z

src/pages/Search/SearchPage.tsx

@@ -45,7 +45,10 @@ function SearchPage({route}: SearchPageProps) {
                    <>
                        <SearchPageHeader queryJSON={queryJSON} />
                        <SearchStatusBar queryJSON={queryJSON} />
-                        <Search queryJSON={queryJSON} />
+                        <Search
+                            key={queryJSON.hash}


To be honest, I'd never have used key if it wasn't an item inside a list. I'm not sure if this is the most efficient way to handle such cases. What's the issue with using an useEffect to handle this issue?
(Updated: I've just found the reconciliation article from react team and I think that's fine to use key here).

Also, this is the component for large screen only, we're using separate component for narrow layout and I believe we should fix the issue on narrow layout as well. Given that both narrow layout and large screen layout are using the Search component. I think we should fix this issue inside Search component.

Checkout this comment section for more info:

App/src/pages/Search/SearchPage.tsx

Lines 26 to 30 in 73f2714

// On small screens this page is not displayed, the configuration is in the file: src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/index.tsx

// To avoid calling hooks in the Search component when this page isn't visible, we return null here.

if (shouldUseNarrowLayout) {

return null;

}

Thank you @hungvu193, let me check this.

@hungvu193 I have updated code for mobile screen and added video evidence as well for Small Screen. Can you please review again? Thanks

Thanks. I'll check it

@ishakakkad Please update your screenshots to video, I don't think screenshots are enough to prove that your solution fixed the issue.

Ok, I will add videos in sometime.

I have added videos of all the platform except Android, I am facing issue in Android build. Will add android build as soon as I fixed it.

Added video for Android as well.

hungvu193 · 2025-01-22T11:11:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-23.at.14.54.42.mov

Android: mWeb Chrome

mChrome.mov

iOS: Native

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

hungvu193 · 2025-01-22T11:12:06Z

Cool. All good, there's android native left that I'm having issue with running the project, I'll try again after couple of hours.

luacmartins · 2025-01-22T14:08:39Z

Thanks for pushing this through! Let's try to get it merged today!

…t-showing

ishakakkad · 2025-01-22T15:54:11Z

@luacmartins can you please approve the build? I have merged the latest changes into branch which should fix the eslint issues.

hungvu193 · 2025-01-22T16:00:40Z

Approved the PR. Still stuck to make Android build successfully, but I'll update it ASAP.

luacmartins

LGTM and tests well

OSBotify · 2025-01-22T16:21:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:29:43Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:53:11Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Draft report not showing in the draft status filter

d31429c

luacmartins self-requested a review January 21, 2025 20:09

ishakakkad marked this pull request as ready for review January 21, 2025 22:00

ishakakkad requested a review from a team as a code owner January 21, 2025 22:00

melvin-bot bot requested review from hungvu193 and removed request for a team January 21, 2025 22:00

Fix prettier

1395b1d

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 21, 2025

@ishakakkad has signed the CLA in Expensify/App#55544

926af6a

Fix eslint issues

e530cee

Merge remote-tracking branch 'origin/main' into 55235-draft-report-no…

c2dd25b

…t-showing

hungvu193 suggested changes Jan 22, 2025

View reviewed changes

ishakakkad force-pushed the 55235-draft-report-not-showing branch from 895344b to c2dd25b Compare January 22, 2025 10:31

ishakakkad added 2 commits January 22, 2025 16:04

Fix issue for mobile screen.

25fdc7d

Fix eslint issues

732cd5b

ishakakkad requested a review from hungvu193 January 22, 2025 10:51

Merge remote-tracking branch 'origin/main' into 55235-draft-report-no…

183e9b4

…t-showing

hungvu193 approved these changes Jan 22, 2025

View reviewed changes

luacmartins approved these changes Jan 22, 2025

View reviewed changes

luacmartins merged commit 066d5eb into Expensify:main Jan 22, 2025
17 of 18 checks passed

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

mohit6789 mentioned this pull request Jan 25, 2025

[Due for payment 2025-02-18] [$250] Report isn't showing most recent chats until refreshed #54785

Closed

8 tasks

melvin-bot bot mentioned this pull request Jan 28, 2025

[HOLD for payment 2025-02-04] [$250] Reports page - Draft report not showing in the draft status filter #55235

Closed

8 tasks

	// On small screens this page is not displayed, the configuration is in the file: src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/index.tsx
	// To avoid calling hooks in the Search component when this page isn't visible, we return null here.
	if (shouldUseNarrowLayout) {
	return null;
	}

Draft report not showing in the draft status filter #55544

Draft report not showing in the draft status filter #55544

Uh oh!

Conversation

ishakakkad commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jan 21, 2025

Uh oh!

luacmartins commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Jan 21, 2025

Uh oh!

ishakakkad commented Jan 21, 2025

Uh oh!

ishakakkad commented Jan 21, 2025

Uh oh!

luacmartins commented Jan 21, 2025

Uh oh!

ishakakkad commented Jan 21, 2025

Uh oh!

hungvu193 commented Jan 22, 2025

Uh oh!

hungvu193 Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Jan 22, 2025

Uh oh!

luacmartins commented Jan 22, 2025

Uh oh!

ishakakkad commented Jan 22, 2025

Uh oh!

hungvu193 commented Jan 22, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

Uh oh!

ishakakkad commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

luacmartins commented Jan 21, 2025 •

edited

Loading

hungvu193 Jan 22, 2025 •

edited

Loading

hungvu193 commented Jan 22, 2025 •

edited

Loading