Skip to content

fix: Workspace - Default label tooltip content is truncated when language is Spanish. #55506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: Workspace - Default label tooltip content is truncated when language is Spanish. #55506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b526a
fix: Workspace - Default label tooltip content is truncated when lang…
Krishna2323 Jan 21, 2025
2452772
fix ESLint.
Krishna2323 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pages/workspace/WorkspacesListRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import useLocalize from '@hooks/useLocalize';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import * as PersonalDetailsUtils from '@libs/PersonalDetailsUtils';
import {getDisplayNameOrDefault, getPersonalDetailsByIDs} from '@libs/PersonalDetailsUtils';
import {getUserFriendlyWorkspaceType} from '@libs/PolicyUtils';
import type {AvatarSource} from '@libs/UserUtils';
import type {AnchorPosition} from '@styles/index';
Expand Down Expand Up @@ -120,7 +120,7 @@ function WorkspacesListRow({
const threeDotsMenuContainerRef = useRef<View>(null);
const {shouldUseNarrowLayout} = useResponsiveLayout();

const ownerDetails = ownerAccountID && PersonalDetailsUtils.getPersonalDetailsByIDs([ownerAccountID], currentUserPersonalDetails.accountID).at(0);
const ownerDetails = ownerAccountID && getPersonalDetailsByIDs([ownerAccountID], currentUserPersonalDetails.accountID).at(0);

if (layoutWidth === CONST.LAYOUT_WIDTH.NONE) {
// To prevent layout from jumping or rendering for a split second, when
Expand Down Expand Up @@ -149,6 +149,7 @@ function WorkspacesListRow({
<Tooltip
maxWidth={variables.w184}
text={translate('workspace.common.defaultNote')}
numberOfLines={4}
>
<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.justifyContentEnd]}>
<Badge
Expand Down Expand Up @@ -225,7 +226,7 @@ function WorkspacesListRow({
<View style={styles.flex1}>
<WorkspacesListRowDisplayName
isDeleted={isDeleted}
ownerName={PersonalDetailsUtils.getDisplayNameOrDefault(ownerDetails)}
ownerName={getDisplayNameOrDefault(ownerDetails)}
/>
<Text
numberOfLines={1}
Expand Down
Loading