fix: unable to receive New Magic Codes for Primary Contact #55498

nkdengineer · 2025-01-21T03:30:30Z

Explanation of Change

Fixed Issues

$ #55405
PROPOSAL: #55405 (comment)

Tests

Create a new account.
Navigate to Settings > Profile > Contact Methods.
Click on the primary contact method to initiate the validation process:
Go back, and click on the primary contact method again.
Verify that: Magic code is sent

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-mweb-resize.mp4

Android: mWeb Chrome

android-resize.mp4

iOS: Native

ios-resize.mp4

iOS: mWeb Safari

ios-mweb-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

dekstop.mov

melvin-bot · 2025-01-21T17:42:24Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-01-21T17:44:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Uploading android.mov…

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2025-01-21T17:46:31Z

@nkdengineer
We need to update the branch to the latest version of main to fix eslint issues

nkdengineer · 2025-01-23T09:27:41Z

@ZhenjaHorbach i merged

ZhenjaHorbach · 2025-01-23T10:10:08Z

@ZhenjaHorbach i merged

Nice
Thanks
I will complete checklist today !

ZhenjaHorbach · 2025-01-23T15:41:17Z

LGTM !

OSBotify · 2025-01-23T19:47:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-28T02:16:28Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-29T06:24:16Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

s77rt · 2025-02-15T13:11:08Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+    useEffect(() => {
+        resetContactMethodValidateCodeSentState(contactMethod);
+    }, [contactMethod]);


This caused the loginData.validatedDate to briefly turn undefined even if the user is actually verified. This triggered the above navigation effect which made it impossible to enter this page. #56355

We should have called resetContactMethodValidateCodeSentState only for non verified contacts.

fedirjh · 2025-04-02T18:02:30Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+    useEffect(() => {
+        resetContactMethodValidateCodeSentState(contactMethod);
+    }, [contactMethod]);


Coming from #57870, when the contact method is removed, this hook will be triggered causing an RBR; we should avoid this call whenever the contact method has a pending delete action.

nkdengineer added 3 commits January 21, 2025 10:30

fix: unable to receive New Magic Codes for Primary Contact

b4673c8

fix lint

3a61912

fix lint

adc61ce

nkdengineer marked this pull request as ready for review January 21, 2025 17:42

nkdengineer requested a review from a team as a code owner January 21, 2025 17:42

melvin-bot bot requested a review from ZhenjaHorbach January 21, 2025 17:42

melvin-bot bot removed the request for review from a team January 21, 2025 17:42

Merge branch 'main' into fix/55405

191eeb9

ZhenjaHorbach approved these changes Jan 23, 2025

View reviewed changes

melvin-bot bot requested a review from cristipaval January 23, 2025 15:41

cristipaval approved these changes Jan 23, 2025

View reviewed changes

cristipaval merged commit 03f18cc into Expensify:main Jan 23, 2025
17 checks passed

github-actions bot mentioned this pull request Jan 28, 2025

Deploy Checklist: New Expensify 2025-01-28 #55824

Closed

82 tasks

melvin-bot bot mentioned this pull request Jan 29, 2025

[HOLD for payment 2025-02-05] [$250] Unable to receive New Magic Codes for Primary Contact #55405

Closed

8 tasks

s77rt reviewed Feb 15, 2025

View reviewed changes

s77rt mentioned this pull request Feb 15, 2025

[Due for payment 2025-02-19] [$250] iOS - Contact method - Nothing happens on tapping the main email & secondary contact in contact methods page #56355

Closed

8 tasks

linhvovan29546 mentioned this pull request Mar 15, 2025

fix: RBR appears in profile after remove second contact #58161

Merged

50 tasks

fedirjh reviewed Apr 2, 2025

View reviewed changes

fedirjh mentioned this pull request Apr 2, 2025

[Due for payment 2025-03-27] [$250] Profile - RBR appears in Profile settings after removing second contact method #57870

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: unable to receive New Magic Codes for Primary Contact #55498

fix: unable to receive New Magic Codes for Primary Contact #55498

Uh oh!

nkdengineer commented Jan 21, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jan 21, 2025

Uh oh!

ZhenjaHorbach commented Jan 21, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Jan 21, 2025

Uh oh!

nkdengineer commented Jan 23, 2025

Uh oh!

ZhenjaHorbach commented Jan 23, 2025

Uh oh!

ZhenjaHorbach commented Jan 23, 2025

Uh oh!

Uh oh!

OSBotify commented Jan 23, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

s77rt Feb 15, 2025

Uh oh!

fedirjh Apr 2, 2025

Uh oh!

Uh oh!

fix: unable to receive New Magic Codes for Primary Contact #55498

fix: unable to receive New Magic Codes for Primary Contact #55498

Uh oh!

Conversation

nkdengineer commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 21, 2025

Uh oh!

ZhenjaHorbach commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jan 21, 2025

Uh oh!

nkdengineer commented Jan 23, 2025

Uh oh!

ZhenjaHorbach commented Jan 23, 2025

Uh oh!

ZhenjaHorbach commented Jan 23, 2025

Uh oh!

Uh oh!

OSBotify commented Jan 23, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

s77rt Feb 15, 2025

Choose a reason for hiding this comment

Uh oh!

fedirjh Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nkdengineer commented Jan 21, 2025 •

edited

Loading

ZhenjaHorbach commented Jan 21, 2025 •

edited

Loading