-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[No QA] [HelpDot]: add new route and article skeleton to newdot documentation #55385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@Pujan92 @flaviadefaria One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@Pujan92 i don't think so this would need a C+ review |
@joekaufmanexpensify this one is ready to get merged |
I need the preview of the ExpensifyHelp page so that I can review it. @joekaufmanexpensify @allgandalf can you link it to me? ![]() |
That deployed page doesn't get created for pull request created by external contributors: ![]() So i'm not sure how to test this one using a link @joekaufmanexpensify do you have any idea here? Either ways I can put up a video for you guys navigating through the new changes, let me know |
I also do not. Reviewing with a video sounds good to me for now. If there are any issues with the first article, I am happy to clean it up with a follow up PR. Sound good @flaviadefaria ? |
Yep, sounds good! |
Screen.Recording.2025-01-22.at.8.36.07.PM.mov |
Video looks great to me, thanks @allgandalf! @flaviadefaria if you want to see the MD formatting for the article, it is also here. Chat GPT/marketing reviewed it too. |
@Pujan92 Could you approve so this gets assigned to an internal engineer? |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #55325 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Thanks Andrew! |
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.89-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀
|
Explanation of Change
Fixed Issues
$ #55325
PROPOSAL: N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop