When hovering over the actionable option wrong option is selected #55350

rinej · 2025-01-16T14:47:28Z

Explanation of Change

Problem
When hovering over the actionable "Whisper" option of a track expense, the wrong option is highlighted, or the field does not get highlighted at all. This issue occurs only in the Safari browser.

Solution
This behaviour may be related to how Safari handles certain events, particularly in scenarios with nested hoverable components.
To address this issue in Safari, the component should be refreshed after rendering. It ensures that all references are properly updated. This fix will be applied conditionally for Safari only, as the existing logic functions correctly in all other browsers.

Before:

Bug.mp4

After:

Fixed.mp4

Fixed Issues

$ #54520
PROPOSAL: #54520 (comment)

Tests

Offline tests

QA Steps

Open web App in Safari Browser
Navigate to the Self DM
Track a manual expense
Hover over the actionable whisper options
See that the proper option is highlighted

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

DesktopHover.mp4

MacOS: Desktop

DesktopHover.mp4

…tion,-the-wrong-option-is-highlighted

melvin-bot · 2025-01-16T14:47:58Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2025-01-19T18:15:21Z

@rinej Thanks for the PR.
Can we please upload the screenshots/videos for the affected platforms (e.g., Desktop)? Also, please fix the ESLint errors here.

…ng-option-is-selected

jayeshmangwani · 2025-01-20T11:33:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-chrome.mov

web-safari.mov

MacOS: Desktop

desktop.mov

rinej · 2025-01-20T11:40:11Z

There were some changes on main regarding eslint, after merging it back it is fixed.
I added some recordings from Desktop and chrome browser, in addition to Safari :)

jayeshmangwani · 2025-01-20T11:50:51Z

Thank you for making the changes; changes works well on Safari!
Also I feel that we should update the comment to make it clearer why we added the scrollToBottom change and what issue it resolves.

jayeshmangwani

LGTM 🚀

melvin-bot · 2025-01-20T11:51:12Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #54520 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

rinej · 2025-01-21T08:47:51Z

Thanks @jayeshmangwani!
I added description before the useEffect -> https://github.com/Expensify/App/pull/55350/files#diff-42d45a343b031265784f22ea27e4502b3c1968e492b1fc83154414b584d59217R447
Is it enough?

…ng-option-is-selected

jayeshmangwani · 2025-01-23T16:26:08Z

@youssef-lr Tagging you here for review, as Melvin assigned you to the issue but failed to request your review.

jayeshmangwani · 2025-01-31T09:10:04Z

@rinej can you please merge main again to resolve the conflicts?

youssef-lr · 2025-01-31T21:28:54Z

We have conflicts @rinej

youssef-lr · 2025-01-31T21:29:26Z

I'm going OOO Monday, please ask for review from someone else when this is done 🙏🏼

jayeshmangwani · 2025-02-04T11:03:10Z

@rinej Please merge the main branch to resolve conflicts. Then, we can ask an internal engineer to merge this PR.

…ng-option-is-selected

rinej · 2025-02-10T11:11:29Z

@jayeshmangwani I just merged the main

rinej · 2025-02-17T10:30:23Z

@jayeshmangwani do we have any update about the reviewer?

jayeshmangwani · 2025-02-17T10:39:54Z

We didn’t get any volunteers for the review, but @youssef-lr is back from OOO today, so hopefully, they can merge it.

OSBotify · 2025-02-17T21:09:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-18T06:29:57Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.1.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-19T03:19:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.0-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

rinej added 6 commits January 15, 2025 13:33

fix hover effect on iou on safari

a1c8869

make sure scrolling happes only when action is new

1fb5f17

add proper const

c60c5f5

fix lint

8268f9d

add code comments

a0f6036

Merge branch 'main' into When-hovering-over-the-actionable-whisper-op…

7803478

…tion,-the-wrong-option-is-highlighted

rinej marked this pull request as ready for review January 16, 2025 14:47

rinej requested a review from a team as a code owner January 16, 2025 14:47

melvin-bot bot requested review from jayeshmangwani and removed request for a team January 16, 2025 14:47

rinej mentioned this pull request Jan 16, 2025

[Due for payment 2025-02-26] [$250] Mac/Safari - Expenses - When hovering over the actionable whisper option, the wrong option is highlighted #54520

Closed

8 tasks

Merge branch 'main' into When-hovering-over-the-actionable-option-wro…

f948812

…ng-option-is-selected

jayeshmangwani approved these changes Jan 20, 2025

View reviewed changes

Merge branch 'main' into When-hovering-over-the-actionable-option-wro…

3885172

…ng-option-is-selected

jayeshmangwani approved these changes Jan 31, 2025

View reviewed changes

melvin-bot bot requested a review from youssef-lr January 31, 2025 09:05

youssef-lr previously approved these changes Jan 31, 2025

View reviewed changes

Merge branch 'main' into When-hovering-over-the-actionable-option-wro…

aab0603

…ng-option-is-selected

rinej dismissed youssef-lr’s stale review via aab0603 February 10, 2025 10:18

youssef-lr approved these changes Feb 17, 2025

View reviewed changes

youssef-lr merged commit 65a591a into Expensify:main Feb 17, 2025
17 checks passed

github-actions bot mentioned this pull request Feb 18, 2025

Deploy Checklist: New Expensify 2025-02-18 #56992

Closed

27 tasks

When hovering over the actionable option wrong option is selected #55350

When hovering over the actionable option wrong option is selected #55350

Uh oh!

Conversation

rinej commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 16, 2025

Uh oh!

jayeshmangwani commented Jan 19, 2025

Uh oh!

jayeshmangwani commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rinej commented Jan 20, 2025

Uh oh!

jayeshmangwani commented Jan 20, 2025

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 20, 2025

Uh oh!

rinej commented Jan 21, 2025

Uh oh!

jayeshmangwani commented Jan 23, 2025

Uh oh!

jayeshmangwani commented Jan 31, 2025

Uh oh!

youssef-lr commented Jan 31, 2025

Uh oh!

youssef-lr commented Jan 31, 2025

Uh oh!

jayeshmangwani commented Feb 4, 2025

Uh oh!

rinej commented Feb 10, 2025

Uh oh!

rinej commented Feb 17, 2025

Uh oh!

jayeshmangwani commented Feb 17, 2025

Uh oh!

Uh oh!

OSBotify commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Uh oh!

rinej commented Jan 16, 2025 •

edited

Loading

jayeshmangwani commented Jan 20, 2025 •

edited

Loading