-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix: In 2FA magic code page, after refresh briefly error message is displayed #55332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
errorText={formError?.validateCode ? translate(formError?.validateCode) : ErrorUtils.getLatestErrorMessage(account ?? {})} | ||
hasError={!isEmptyObject(validateError)} | ||
errorText={ | ||
canShowError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please define the new variable for errorText within useMemo?
@nyomanjyotisa Please add |
PR updated @dominictb |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeScreen.Recording.2025-01-16.at.15.48.59.moviOS: mWeb SafariScreen.Recording.2025-01-16.at.15.49.30.movMacOS: Chrome / SafariScreen.Recording.2025-01-16.at.15.47.18.movMacOS: DesktopScreen.Recording.2025-01-17.at.11.15.30.mov |
Thank @nyomanjyotisa |
@cead22 Can you take a look at this PR? |
@dominictb can you complete this step? I see an error in the Android: Native screenshot |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.89-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀
|
Explanation of Change
Fixed Issues
$ #54009
PROPOSAL: #54009 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Pre-condition: Login with unverified Gmail account
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Unable to test on native Android since the page cannot be refreshed/reloadedAndroid: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
Unable to test on native iOS since the page cannot be refreshed/reloadediOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4
MacOS: Desktop
MacOS-Desktop.mp4