-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Early discount countdown banner #54901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
youssef-lr
merged 22 commits into
Expensify:main
from
parasharrajat:parasharrajat/early-discount
Jan 24, 2025
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ad94f68
Create discount component
youssef-lr f997719
Add banner to subscription page
youssef-lr 72cb79b
Merge branch 'main' into youssef_early_discount
youssef-lr 70ffbfa
Make 25% discount banner dismissable
youssef-lr 47440ab
Merge branch 'main' into youssef_early_discount
youssef-lr 498fc03
Merge branch 'main' of github.com:Expensify/App into parasharrajat/ea…
parasharrajat 6163322
Code cleanup
parasharrajat f6468dd
add tests for utils
parasharrajat 8ba3ed9
Formatting and translations
parasharrajat 9538707
translations and fixes
parasharrajat 466fdbe
Merge branch 'main' of github.com:Expensify/App into parasharrajat/ea…
parasharrajat 812184c
Fix lint issues
parasharrajat b2a4b01
Add claim param to API
parasharrajat aba6f2c
Fix banner styles
parasharrajat 8e8be55
Fix type
parasharrajat 42ac964
message fix
parasharrajat fe443be
Make the banner reative so that it shows up when the report loads imm…
parasharrajat b30fd64
Merge branch 'main' of github.com:Expensify/App into parasharrajat/ea…
parasharrajat 4129a23
Small Fix
parasharrajat 4d5be96
Merge branch 'main' of github.com:Expensify/App into parasharrajat/ea…
parasharrajat d4e9135
Apply suggestions from code review
parasharrajat 7a9084e
small fixes
parasharrajat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be called
discountAmount
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe not. the value is 50, 25. Technically, it is not amount. It is percentage of discount. I kept the same terminology used for discount info.