Add contacts import nitro module #54459
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # OSX | ||
| # | ||
| .DS_Store | ||
|
|
||
| # XDE | ||
| .expo/ | ||
|
|
||
| # VSCode | ||
| .vscode/ | ||
| jsconfig.json | ||
|
|
||
| # Xcode | ||
| # | ||
| build/ | ||
| *.pbxuser | ||
| !default.pbxuser | ||
| *.mode1v3 | ||
| !default.mode1v3 | ||
| *.mode2v3 | ||
| !default.mode2v3 | ||
| *.perspectivev3 | ||
| !default.perspectivev3 | ||
| xcuserdata | ||
| *.xccheckout | ||
| *.moved-aside | ||
| DerivedData | ||
| *.hmap | ||
| *.ipa | ||
| *.xcuserstate | ||
| project.xcworkspace | ||
|
|
||
| # Android/IJ | ||
| # | ||
| .classpath | ||
| .cxx | ||
| .gradle | ||
| .idea | ||
| .project | ||
| .settings | ||
| local.properties | ||
| android.iml | ||
|
|
||
| # Cocoapods | ||
| # | ||
| example/ios/Pods | ||
|
|
||
| # Ruby | ||
| example/vendor/ | ||
|
|
||
| # node.js | ||
| # | ||
| node_modules/ | ||
| npm-debug.log | ||
| yarn-debug.log | ||
| yarn-error.log | ||
|
|
||
| # BUCK | ||
| buck-out/ | ||
| \.buckd/ | ||
| android/app/libs | ||
| android/keystores/debug.keystore | ||
|
|
||
| # Expo | ||
| .expo/ | ||
|
|
||
| # Turborepo | ||
| .turbo/ | ||
|
|
||
| # generated by bob | ||
| lib/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| require "json" | ||
|
|
||
| package = JSON.parse(File.read(File.join(__dir__, "package.json"))) | ||
|
|
||
| Pod::Spec.new do |s| | ||
| s.name = "ExpensifyNitroUtils" | ||
| s.version = package["version"] | ||
| s.summary = package["description"] | ||
| s.homepage = package["homepage"] | ||
| s.license = package["license"] | ||
| s.authors = package["author"] | ||
|
|
||
| s.platforms = { :ios => min_ios_version_supported } | ||
|
There was a problem hiding this comment. is min_ios_version_supported defined automatically somewhere? There was a problem hiding this comment. If it's not defined there it will pick up version form root podfile |
||
| s.source = { :git => "https://github.com/mrousavy/nitro.git", :tag => "#{s.version}" } | ||
|
|
||
| s.source_files = [ | ||
| # Implementation (Swift) | ||
| "ios/**/*.{swift}", | ||
| # Autolinking/Registration (Objective-C++) | ||
| "ios/**/*.{m,mm}", | ||
| # Implementation (C++ objects) | ||
| "cpp/**/*.{hpp,cpp}", | ||
| ] | ||
|
|
||
| load 'nitrogen/generated/ios/ExpensifyNitroUtils+autolinking.rb' | ||
| add_nitrogen_files(s) | ||
|
|
||
| install_modules_dependencies(s) | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| project(ExpensifyNitroUtils) | ||
| cmake_minimum_required(VERSION 3.9.0) | ||
|
|
||
| set (PACKAGE_NAME ExpensifyNitroUtils) | ||
| set (CMAKE_VERBOSE_MAKEFILE ON) | ||
| set (CMAKE_CXX_STANDARD 20) | ||
roryabraham marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Define C++ library and add all sources | ||
| add_library(${PACKAGE_NAME} SHARED | ||
| src/main/cpp/cpp-adapter.cpp | ||
| ) | ||
|
|
||
| # Add Nitrogen specs :) | ||
| include(${CMAKE_SOURCE_DIR}/../nitrogen/generated/android/ExpensifyNitroUtils+autolinking.cmake) | ||
|
|
||
| # Set up local includes | ||
| include_directories( | ||
| "src/main/cpp" | ||
| "../cpp" | ||
| ) | ||
|
|
||
| find_library(LOG_LIB log) | ||
|
|
||
| # Link all libraries together | ||
| target_link_libraries( | ||
| ${PACKAGE_NAME} | ||
| ${LOG_LIB} | ||
| android # <-- Android core | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| buildscript { | ||
| repositories { | ||
| google() | ||
| mavenCentral() | ||
| } | ||
|
|
||
| dependencies { | ||
| classpath "com.android.tools.build:gradle:7.2.1" | ||
| } | ||
| } | ||
|
|
||
| def reactNativeArchitectures() { | ||
| def value = rootProject.getProperties().get("reactNativeArchitectures") | ||
| return value ? value.split(",") : ["armeabi-v7a", "x86", "x86_64", "arm64-v8a"] | ||
| } | ||
|
|
||
| def isNewArchitectureEnabled() { | ||
| return rootProject.hasProperty("newArchEnabled") && rootProject.getProperty("newArchEnabled") == "true" | ||
| } | ||
|
|
||
| apply plugin: "com.android.library" | ||
| apply plugin: 'org.jetbrains.kotlin.android' | ||
| apply from: '../nitrogen/generated/android/ExpensifyNitroUtils+autolinking.gradle' | ||
|
|
||
| if (isNewArchitectureEnabled()) { | ||
| apply plugin: "com.facebook.react" | ||
| } | ||
|
|
||
| def getExtOrDefault(name) { | ||
| return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties["ExpensifyNitroUtils_" + name] | ||
| } | ||
|
|
||
| def getExtOrIntegerDefault(name) { | ||
| return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties["ExpensifyNitroUtils_" + name]).toInteger() | ||
| } | ||
|
|
||
| android { | ||
| namespace "com.margelo.nitro.utils" | ||
| ndkVersion getExtOrDefault("ndkVersion") | ||
| compileSdkVersion getExtOrIntegerDefault("compileSdkVersion") | ||
|
|
||
| defaultConfig { | ||
| minSdkVersion getExtOrIntegerDefault("minSdkVersion") | ||
| targetSdkVersion getExtOrIntegerDefault("targetSdkVersion") | ||
| buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString() | ||
|
|
||
| externalNativeBuild { | ||
| cmake { | ||
| cppFlags "-O2 -frtti -fexceptions -Wall -fstack-protector-all" | ||
| arguments "-DANDROID_STL=c++_shared" | ||
| abiFilters (*reactNativeArchitectures()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| externalNativeBuild { | ||
| cmake { | ||
| path "CMakeLists.txt" | ||
| } | ||
| } | ||
|
|
||
| packagingOptions { | ||
| excludes = [ | ||
| "META-INF", | ||
| "META-INF/**", | ||
| "**/libc++_shared.so", | ||
| "**/libfbjni.so", | ||
| "**/libjsi.so", | ||
| "**/libfolly_json.so", | ||
| "**/libfolly_runtime.so", | ||
| "**/libglog.so", | ||
| "**/libhermes.so", | ||
| "**/libhermes-executor-debug.so", | ||
| "**/libhermes_executor.so", | ||
| "**/libreactnativejni.so", | ||
| "**/libturbomodulejsijni.so", | ||
| "**/libreact_nativemodule_core.so", | ||
| "**/libjscexecutor.so" | ||
| ] | ||
| } | ||
|
|
||
| buildFeatures { | ||
| buildConfig true | ||
| prefab true | ||
| } | ||
|
|
||
| buildTypes { | ||
| release { | ||
| minifyEnabled false | ||
| } | ||
| } | ||
|
|
||
| lintOptions { | ||
| disable "GradleCompatible" | ||
| } | ||
|
|
||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_17 | ||
| targetCompatibility JavaVersion.VERSION_17 | ||
| } | ||
|
|
||
| sourceSets { | ||
| main { | ||
| if (isNewArchitectureEnabled()) { | ||
| java.srcDirs += [ | ||
| // React Codegen files | ||
| "${project.buildDir}/generated/source/codegen/java" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() | ||
| google() | ||
| } | ||
|
|
||
|
|
||
| dependencies { | ||
| // For < 0.71, this will be from the local maven repo | ||
| // For > 0.71, this will be replaced by `com.facebook.react:react-android:$version` by react gradle plugin | ||
| //noinspection GradleDynamicVersion | ||
| implementation "com.facebook.react:react-native:+" | ||
|
|
||
| // Add a dependency on NitroModules | ||
| implementation project(":react-native-nitro-modules") | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally very difficult to review changes in this file, but can you try just removing all the changes in this file, then surgically add back only the ones that are strictly necessary here? Looking at some of the changes, it looks like you might've checked "automatically manage signing" or whatever that checkbox is in XCode. That can help you get a passing build without setting up the manual provisioning profile, but might break prod builds and we don't want to commit the change.