Use the full screen loader for PDF View #5390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
27 tasks
|
🚀 Deployed to staging by @robertjchen in version: 1.1.1-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @parasharrajat for the pointer and sorry I had to make this quick change last minute and couldn't UpWork it.
Details
Using the
loadingprop for the Web view to show our customFullscreenLoadingIndicatorand using theactivityIndicatorprop to show the same on Native.Fixed Issues
$ #4997
Tests & QA Steps
Loading PDF...Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
screen-20210921-181349.mp4