Skip to content

Use the full screen loader for PDF View #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Use the full screen loader for PDF View #5390

merged 1 commit into from
Sep 22, 2021

Conversation

Dal-Papa
Copy link

@Dal-Papa Dal-Papa commented Sep 21, 2021

Thanks @parasharrajat for the pointer and sorry I had to make this quick change last minute and couldn't UpWork it.

Details

Using the loading prop for the Web view to show our custom FullscreenLoadingIndicator and using the activityIndicator prop to show the same on Native.

Fixed Issues

$ #4997

Tests & QA Steps

  1. Send a PDF as an attachment to a chat
  2. Once the PDF is uploaded and you can see the thumbnail, click on it
  3. Verify that you see the standard circle loading instead of Loading PDF...

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

screencast 2021-09-21 18-19-10

Mobile Web

screencast 2021-09-21 18-20-28

Desktop

iOS

Android

screen-20210921-181349.mp4

@Dal-Papa Dal-Papa requested a review from a team September 21, 2021 16:21
@Dal-Papa Dal-Papa self-assigned this Sep 21, 2021
@MelvinBot MelvinBot requested review from robertjchen and removed request for a team September 21, 2021 16:21
Copy link
Contributor

@robertjchen robertjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@robertjchen robertjchen merged commit 273b138 into main Sep 22, 2021
@robertjchen robertjchen deleted the clem-pdf-loading branch September 22, 2021 18:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @robertjchen in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants