Fix Additional Information Text Margin #5363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luacmartins
commented
Sep 20, 2021
| @@ -224,7 +224,7 @@ class BeneficialOwnersStep extends React.Component { | |||
| )} | |||
| </View> | |||
| )} | |||
| <Text style={[styles.textStrong, styles.mb5]}> | |||
| <Text style={[styles.textStrong, styles.mv5]}> | |||
There was a problem hiding this comment.
Added a top margin to separate "Agreement" from the top checkboxes and make it look more like @shawnborton's image.
luacmartins
commented
Sep 20, 2021
| @@ -235,7 +235,7 @@ class BeneficialOwnersStep extends React.Component { | |||
| <View style={[styles.flexRow]}> | |||
| <Text>{this.props.translate('common.iAcceptThe')}</Text> | |||
| <TextLink href="https://use.expensify.com/achterms"> | |||
| {`${this.props.translate('beneficialOwnersStep.termsAndConditions')}.`} | |||
| {`${this.props.translate('beneficialOwnersStep.termsAndConditions')}`} | |||
There was a problem hiding this comment.
Removed "." to make it consistent with the other checkbox items.
|
I think you can also make the "Agreement" use a normal font weight and not bold. |
|
Updated! |
|
Looks good, thanks Carlos! |
Dal-Papa
approved these changes
Sep 21, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the margin on the additional information page.
Fixed Issues
$ #5343
Tests
QA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android