cleanup: split filtering & ordering in OptionsListUtils

src/libs/OptionsListUtils.ts

@@ -1703,6 +1703,11 @@ function filterOptions(options: Options, searchInputValue: string, config?: Filt
 }
 
 type FilterAndOrderConfig = FilterUserToInviteConfig & OrderOptionsConfig;
+
+/**
+ * Filters and orders the options based on the search input value.
+ * Note that personal details that are part of the recent reports will always be shown as part of the recent reports (ie. DMs).
+ */
 function filterAndOrderOptions(options: Options, searchInputValue: string, config: FilterAndOrderConfig = {}): Options {
     const {maxRecentReportsToShow = 0, sortByReportTypeInSearch = false} = config;
 

tests/unit/OptionsListUtilsTest.ts

@@ -983,6 +983,16 @@ describe('OptionsListUtils', () => {
                     expect(filteredResults.recentReports.at(0)?.text).toBe('The Flash');
                 });
         });
+
+        it('should return all results when setting maxRecentReportsToShow to 0', () => {
+            const options = OptionsListUtils.getSearchOptions(OPTIONS);
+            const filteredOptions = OptionsListUtils.filterAndOrderOptions(options, '', {maxRecentReportsToShow: 0});
+
+            expect(filteredOptions.recentReports.length).toBe(10);
+            // There are only two personal details that have no reports. Personal details will be
+            // excluded from the list if they have reports (DMs).
+            expect(filteredOptions.personalDetails.length).toBe(2);
+        });
     });
 
     describe('canCreateOptimisticPersonalDetailOption', () => {