Skip to content

add top padding to LHN wrapper #53296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2024
Merged

add top padding to LHN wrapper #53296

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65bc5fb
add top padding to lhn wrapper
mkzie2 Nov 29, 2024
11df31e
Merge branch 'main' into mkzie2-issue/52198
mkzie2 Dec 6, 2024
2937874
resue spacing style
mkzie2 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,6 +1668,7 @@ const styles = (theme: ThemeColors) =>
},

sidebarListContainer: {
paddingTop: 12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works to me but @mkzie2 can you double check if we use that direct value in other pages like Search Page or workspace list? Curious if there is any existing shared variable on it

Copy link
Contributor Author

@mkzie2 mkzie2 Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used mt3:

App/src/pages/Search/SearchTypeMenu.tsx

Line 251 in 6dff844

<View style={[styles.pb4, styles.mh3, styles.mt3]}>

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 426 in 522bb76

<View style={[styles.pb4, styles.mh3, styles.mt3]}>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, what do you think if we reuse that value? Something like this

        sidebarListContainer: {
            ...spacing.pt3,
            paddingBottom: 4,
        },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoangzinh Agree, I updated.

paddingBottom: 4,
},

Expand Down
Loading