Add Chat with setup specialist to the accounting page. #52803

nkdengineer · 2024-11-20T03:59:25Z

Explanation of Change

Fixed Issues

$ #51487
PROPOSAL: #51487 (comment)

Tests

Login with a new email that is not alias email format(include +)
Create a new workspace
Enable Accounting
Go to the Accounting page
Verify that: Chat with setup specialist to the accounting page is displayed

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-11-20T09:39:03Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2024-11-20T09:39:28Z

@dukenv0307 I am a little stuck on the iOS Native builds, will add later

nkdengineer · 2024-11-20T09:39:56Z

I asked for translation into Spanish here

src/pages/workspace/accounting/PolicyAccountingPage.tsx

src/languages/en.ts

src/languages/es.ts

src/pages/workspace/accounting/PolicyAccountingPage.tsx

nkdengineer · 2024-11-25T05:37:30Z

@dukenv0307 i updated, please check again

danielrvidal · 2024-11-26T21:09:01Z

@dukenv0307 how is the review going?

dukenv0307 · 2024-11-27T16:11:10Z

I'm reviewing.

dukenv0307 · 2024-11-28T16:07:46Z

code looks good

dukenv0307 · 2024-11-28T16:22:54Z

But I think we should get some thoughts from design team. The result below is quite different from the one in the OP

Actual:

Expect:

dukenv0307 · 2024-11-28T16:23:18Z

@Expensify/design ^

dubielzyk-expensify · 2024-11-29T00:49:08Z

Yeah, it looks a bit off. Here's some more detailed specs to help you out:

Also, the text color on this bit should be text-supporting like seen below:

nkdengineer · 2024-11-29T08:21:01Z

@dukenv0307 i updated, please check again

dukenv0307 · 2024-12-01T04:11:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-12-01.at.10.52.35.mov

Screen.Recording.2024-12-01.at.10.53.12.mov

Screen.Recording.2024-12-01.at.10.53.56.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-12-01.at.10.43.34.mov

Screen.Recording.2024-12-01.at.10.46.12.mov

Screen.Recording.2024-12-01.at.10.47.04.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-01.at.10.38.30.mov

MacOS: Desktop

nkdengineer · 2024-12-05T08:45:02Z

thanks @techievivek, It looks like we have data now
cc @dukenv0307

techievivek · 2024-12-05T16:32:40Z

@nkdengineer You will be updating the PR to check for the assigned guide before showing the chat with setup specialist link, right? Just double checking to see if you understand my comment that I posted earlier.

dukenv0307 · 2024-12-06T03:34:33Z

@nkdengineer As we discussed here, we should check if they have a specialist assigned or not first.

nkdengineer · 2024-12-06T08:52:46Z

@techievivek @dukenv0307 Sorry, I’m not entirely clear. Do you mean that we will only show the text below if account.guideDetails exists?

techievivek · 2024-12-06T10:56:29Z

Yeah, we only want to show the link when account.guideDetails.email entry is non-empty.

techievivek · 2024-12-09T07:38:39Z

@nkdengineer Do you need any more clarifications here? Feel free to DM me on Slack if you have any questions, thanks.

nkdengineer · 2024-12-09T09:02:58Z

Thanks @techievivek. I'm clear now. I'll give an update soon

nkdengineer · 2024-12-09T09:20:49Z

@dukenv0307 @techievivek I updated code changes and test steps. Please check again

dukenv0307 · 2024-12-09T10:17:59Z

looks good

@techievivek just mentioned 2 fields in guideDetails, but we have more than that here, should we add all of them @nkdengineer?

techievivek · 2024-12-09T18:30:18Z

email and calendarLink should be fine for now, rest are for internal purposes.

dukenv0307 · 2024-12-10T02:02:49Z

@nkdengineer Can you pls update your PR?

nkdengineer · 2024-12-10T03:32:34Z

@dukenv0307 i updated

techievivek · 2024-12-10T08:28:03Z

@dukenv0307 Can you please do a final review here? Thanks.

dukenv0307 · 2024-12-11T04:40:58Z

Yes, I can

dukenv0307 · 2024-12-11T05:44:21Z

LGTM

OSBotify · 2024-12-11T06:58:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-12T01:58:35Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

danielrvidal · 2024-12-12T18:02:43Z

Looking great on staging!

github-actions · 2024-12-13T15:40:40Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

nkdengineer added 2 commits November 20, 2024 10:58

Add Chat with setup specialist to the accounting page.

cb499a1

fix: add translation key and style

e61abc0

nkdengineer marked this pull request as ready for review November 20, 2024 09:38

nkdengineer requested a review from a team as a code owner November 20, 2024 09:38

melvin-bot bot requested review from dukenv0307 and removed request for a team November 20, 2024 09:39

nkdengineer added 2 commits November 22, 2024 15:08

fix: update accounting translate

c29f6eb

Merge branch 'main' into fix/51487

70d557b

nkdengineer mentioned this pull request Nov 22, 2024

[HOLD for payment 2024-12-20] [$250] Add Chat with setup specialist to the accounting page. #51487

Closed

dukenv0307 reviewed Nov 22, 2024

View reviewed changes

src/pages/workspace/accounting/PolicyAccountingPage.tsx Outdated Show resolved Hide resolved

dukenv0307 reviewed Nov 22, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

dukenv0307 reviewed Nov 22, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

dukenv0307 reviewed Nov 22, 2024

View reviewed changes

src/pages/workspace/accounting/PolicyAccountingPage.tsx Outdated Show resolved Hide resolved

nkdengineer added 2 commits November 25, 2024 12:13

Merge branch 'main' into fix/51487

14175fa

change translation

2efa89f

nkdengineer added 2 commits November 29, 2024 15:12

Merge branch 'main' into fix/51487

9f64323

fix: accounting page style

d3aa2f2

dukenv0307 approved these changes Dec 1, 2024

View reviewed changes

nkdengineer added 3 commits December 9, 2024 16:03

Merge branch 'main' into fix/51487

6f5a071

fix only show accouting link when have guide details

0239ae7

fix lint

89d9f58

nkdengineer mentioned this pull request Dec 9, 2024

[HOLD for payment 2025-01-30] [$250] [New Feature] Add Guide booking link to #admins header #53764

Closed

8 tasks

change type guide details

bbb44e6

dukenv0307 approved these changes Dec 11, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek December 11, 2024 05:44

techievivek approved these changes Dec 11, 2024

View reviewed changes

techievivek merged commit dac90e1 into Expensify:main Dec 11, 2024
17 checks passed

github-actions bot mentioned this pull request Dec 12, 2024

Deploy Checklist: New Expensify 2024-12-12 #53978

Closed

55 tasks

lanitochka17 mentioned this pull request Dec 12, 2024

[$250] Onboarding - Onboarding modal closes for manage expenses when arriving on accounting modal #54059

Closed

8 tasks

Add Chat with setup specialist to the accounting page. #52803

Add Chat with setup specialist to the accounting page. #52803

Uh oh!

Conversation

nkdengineer commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 20, 2024

Uh oh!

nkdengineer commented Nov 20, 2024

Uh oh!

nkdengineer commented Nov 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Nov 25, 2024

Uh oh!

danielrvidal commented Nov 26, 2024

Uh oh!

dukenv0307 commented Nov 27, 2024

Uh oh!

dukenv0307 commented Nov 28, 2024

Uh oh!

dukenv0307 commented Nov 28, 2024

Uh oh!

dukenv0307 commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Nov 29, 2024

Uh oh!

nkdengineer commented Nov 29, 2024

Uh oh!

dukenv0307 commented Dec 1, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techievivek commented Dec 5, 2024

Uh oh!

dukenv0307 commented Dec 6, 2024

Uh oh!

nkdengineer commented Dec 6, 2024

Uh oh!

techievivek commented Dec 6, 2024

Uh oh!

techievivek commented Dec 9, 2024

Uh oh!

nkdengineer commented Dec 9, 2024

Uh oh!

nkdengineer commented Dec 9, 2024

Uh oh!

dukenv0307 commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techievivek commented Dec 9, 2024

Uh oh!

dukenv0307 commented Dec 10, 2024

Uh oh!

nkdengineer commented Dec 10, 2024

Uh oh!

techievivek commented Dec 10, 2024

Uh oh!

dukenv0307 commented Dec 11, 2024

Uh oh!

dukenv0307 commented Dec 11, 2024

Uh oh!

Uh oh!

OSBotify commented Dec 11, 2024

Uh oh!

nkdengineer commented Nov 20, 2024 •

edited

Loading

dukenv0307 commented Nov 28, 2024 •

edited

Loading

nkdengineer commented Dec 5, 2024 •

edited

Loading

dukenv0307 commented Dec 9, 2024 •

edited

Loading