Skip to content

fix: translations for Native AttachmentPicker #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

parasharrajat
Copy link
Member

Details

#5103 (comment)

Fixed Issues

$ #5103

Tests | QA Steps

  1. Log in NewDot mobile app.
  2. Open any chat.
  3. Tap on + sign > Add Attachment.
  4. Observe the language of the opened Menu.
  5. Navigate to Settings > Preferences
  6. Set the language to Spanish(if not already selected).
  7. Close the Settings page by clicking close(top-right).
  8. Open the previous chat.
  9. Tap on + sign > Add Attachment.
  10. Observe the language of the opened Menu.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

attachment-picker-a.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner September 10, 2021 19:06
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team September 10, 2021 19:06
@johnmlee101 johnmlee101 merged commit 9bcc643 into Expensify:main Sep 13, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.0.97-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 15, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-22. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the localize branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants