Skip to content

Add feedback to IOU on Max participants selection #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Sep 1, 2021

Details

Fixed Issues

$ #4616

Tests | QA Steps

  1. Open newDot on Mobile.
  2. Click FAB button>split Bill.
  3. Now enter the amount and continue.
  4. On the participant page start selecting participants.
  5. Ensure that you cannot select more than 8 participants and that the message is displayed

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

fg

iOS

Android

gg

@parasharrajat parasharrajat requested a review from a team as a code owner September 1, 2021 18:23
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 1, 2021 18:23
@marcaaron marcaaron requested a review from Julesssss September 1, 2021 18:50
@marcaaron
Copy link
Contributor

Gonna let @Julesssss take this one. Can jump in if need.

@marcaaron marcaaron removed their request for review September 1, 2021 18:51
@Julesssss
Copy link
Contributor

Is this ready for review @parasharrajat? It's not clear to me as some platforms are missing.

@parasharrajat
Copy link
Member Author

@Julesssss Ready for review.

@Julesssss
Copy link
Contributor

Great work as always, thanks @parasharrajat.

BTW, I added a 5th step to your test just to make it absolutely clear for QA

@Julesssss
Copy link
Contributor

Tested iOS and Web.

@Julesssss Julesssss merged commit 504bb08 into Expensify:main Sep 3, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021

🚀 Deployed to staging by @Julesssss in version: 1.0.92-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 3, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-10. 🎊

@OSBotify
Copy link
Contributor

OSBotify commented Sep 4, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants