fix type selector dropdown flicker

[289Adam289]

Details

Fixed Issues

$#49803
PROPOSAL:

Tests

• Open app

• Navigate to Search

• Change type to chat

• Open and close message with attachment

• Verify that type bottom sheet did not flicker

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Open app

• Navigate to Search

• Change type to chat

• Open and close message with attachment

• Verify that type bottom sheet did not flicker

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-09-27.at.16.24.08.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-27.at.16.26.46.mp4

MacOS: Desktop

[adamgrzybowski]

🎸

[melvin-bot]

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[s77rt]

This caused a significant delay in changing the type

Before	After
Screen.Recording.2024-09-27.at.6.51.56.PM.mov	Screen.Recording.2024-09-27.at.6.50.22.PM.mov

[289Adam289]

I am not sure why unfinished animation causes flash of bottom sheet, but fix I implemented is the same code pattern we've already used in app e.g three-dot menu in saved search.
In fix we wait for closing animation to finish and than navigate to another screen.
no delay:

Screen.Recording.2024-09-30.at.09.35.45.mov

delay(on main):

Screen.Recording.2024-09-30.at.09.36.53.mov

[s77rt]

@289Adam289 In this case we can't go with that solution as it causes a worst user experience. I'm guessing the bug occurs because when we open the type selector we open it via the on modal hide callback and that callback still executes when we hide other modals e.g. the attachment modal in this case. Can you please investigate on the root cause before going with other solutions?

[289Adam289]

I will investigate further

[289Adam289]

Solution

After some more investigation I am still not completely sure what is the root cause of the problem and I wasn't able to find solution that doesn't cause delay. My colleague from SWM @BartoszGrajdek is currently working on issues connected to react-native-modal library #49354 which maybe the root cause of this issue and swapping react-native-animatable for react-native-reanimated may solve the problem. I've tried testing his patch and it changes interactions between modals hence it can probably help remove the problem.

Work around

We can also go with solution I've already implemented and try to reduce the delay by removing or shortening closing animation. Getting results like this:

Screen.Recording.2024-10-01.at.15.38.18.mov

[s77rt]

In that case I think we should hold on #49354

[s77rt]

@289Adam289 Can you please close this PR?

[luacmartins]

Let's close it for now.