Skip to content

Fix Plaid modal by updating to latest version of react-native-plaid-link-sdk / resolve stashed token issue #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Fix Plaid modal by updating to latest version of react-native-plaid-link-sdk / resolve stashed token issue #4962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f860d5
Fix Plaid modal
marcaaron Aug 31, 2021
c2f9deb
update pods
marcaaron Aug 31, 2021
4cc51c2
Add log for Plaid events. Fix up loading spinner.
marcaaron Sep 1, 2021
fac3c72
fix conflicts
marcaaron Sep 1, 2021
a7c6932
update comment because I lied
marcaaron Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"react-native-performance": "^2.0.0",
"react-native-permissions": "^3.0.1",
"react-native-picker-select": "8.0.4",
"react-native-plaid-link-sdk": "^7.0.5",
"react-native-plaid-link-sdk": "7.1.0",
"react-native-reanimated": "^2.3.0-alpha.1",
"react-native-render-html": "6.0.0-beta.8",
"react-native-safe-area-context": "^3.1.4",
Expand Down
4 changes: 2 additions & 2 deletions src/CONFIG.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ export default {
DEFAULT: '/favicon.png',
UNREAD: '/favicon-unread.png',
},
CAPTURE_METRICS: lodashGet(Config, 'CAPTURE_METRICS', false),
ONYX_METRICS: lodashGet(Config, 'ONYX_METRICS', false),
CAPTURE_METRICS: lodashGet(Config, 'CAPTURE_METRICS', 'false') === 'true',
ONYX_METRICS: lodashGet(Config, 'ONYX_METRICS', 'false') === 'true',
Copy link
Contributor Author

@marcaaron marcaaron Aug 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: These changes are not related, but I noticed my test builds were showing the metrics despite being set to CAPTURE_METRICS=false in .env file and decided to fix this here.

};
4 changes: 2 additions & 2 deletions src/libs/canCaptureMetrics/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import CONFIG from '../../CONFIG';
*
* @returns {Boolean}
*/
export const canCapturePerformanceMetrics = () => Boolean(CONFIG.CAPTURE_METRICS);
export const canCapturePerformanceMetrics = () => CONFIG.CAPTURE_METRICS;

/**
* Is capturing Onyx stats enabled.
*
* @returns {Boolean}
*/
export const canCaptureOnyxMetrics = () => Boolean(CONFIG.ONYX_METRICS);
export const canCaptureOnyxMetrics = () => CONFIG.ONYX_METRICS;