-
Notifications
You must be signed in to change notification settings - Fork 3.2k
#4517 update timezone on user activity #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tylerkaraszewski
merged 5 commits into
Expensify:main
from
dklymenk:4517-update-timezone-automatically
Aug 30, 2021
Merged
#4517 update timezone on user activity #4799
tylerkaraszewski
merged 5 commits into
Expensify:main
from
dklymenk:4517-update-timezone-automatically
Aug 30, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has conflicts. |
Hello, sorry. Conflict fixed. |
thienlnam
approved these changes
Aug 27, 2021
Looks great! Leaving for you @tylerkaraszewski |
tylerkaraszewski
approved these changes
Aug 30, 2021
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @tylerkaraszewski in version: 1.0.89-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR replaces the original automatic timezone implementation that only checked timezone on app start with a new one, that also checks for updates on specific user activity: send chat message and open profile settings (the 2 places where you will see your current timezone impact rendering).
Fixed Issues
$ #4517
Tests
These are long, but are required to check that the timezone is updated:
QA Steps
Tested On
Screenshots
Web
4517-web.mp4
Mobile Web
4517-mweb.mp4
Desktop
4517-desktop.mp4
iOS
4517-ios.mp4
Android
Sorry for the crash in the middle of the video, reloading with hermes results in crash like 50% of the time for me. Still trying to figure it out
4517-android.mp4