Multiline for ExpensiTextInput

[kakajann]

Details

Fixed Issues

Fixes #4625

Tests

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

Looks good. One thing I noticed is that the Copy for email Input is wrong. It accepts multiple comma-separated emails or phone but the text says Invite a colleague to your workspace?

[kakajann]

I didn't modify anything related email input. This PR's only concern is making new input work with multiline prop.

[parasharrajat]

I didn't modify anything related to email input.

I know. I was just asking maybe a correction can be made, as it's just text. Anyways, it's fine.

[kakajann]

@parasharrajat oh, sorry, I misunderstood 😅

I don't mind changing the text as collaborators suggestion

[shawnborton]

At first glance, it seems like the gap between the textarea label and the value is too large. Here is a regular text input for reference:

And from what I see above:

But maybe that's just my eyes playing tricks on me?

Otherwise can you confirm that the value of the color matches the same text color as text inputs? It appears to be black in the screenshots:

[kakajann]

• Input color was black, changed to themeColors.text (#0b1b34)
• There was a small extra gap between label and input (and I guess it only appears on iOs, maybe because it doesn't support textAlignVertical="top"), so I solved using spacing.pv0.

Also iOs doesn't support numberOfLines prop and on iOs, input height will be as high as its content.

Here is the result

[shawnborton]

The default height of the textarea feels a bit too tall IMO:

Could we make that shorter? Maybe to just 4 or 5 lines or something like that.

[kakajann]

Sure, I'll update in an hour

[AndrewGable]

@shawnborton - Anything else you'd like to see here?

[AndrewGable]

Is this required or related to your change?

[AndrewGable]

Is this required or related to your change?

[kakajann]

@AndrewGable code changes in ios folder is not required neither related. I think Pod automatically updated. Do u want me to revert it?

[AndrewGable]

Can you confirm these changes happen on main? If so, yes we can commit them. Otherwise let's not include them in the branch.

[shawnborton]

@kakajann mind updating your screenshots so I can see if my requested changes were applied? Thanks!

[kakajann]

Latest change: 5 lines

[shawnborton]

Looks good, thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[isagoico]

@kakajann Any QA steps needed for this PR?

[isagoico]

This was tested with the following QA steps:

1. Navigate to the workspace invite page
2. Verify the text box has a bigger size (5 lines) and it's comfortable to type and edit for the user

And it was a pass 🎉 @kakajann please remember to add QA steps for future PRs 🙇

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊