Handle undefined IOU Report on IOUdetails page #4534

parasharrajat · 2021-08-10T22:27:33Z

Details

Fixed Issues

$ Fixes #4362

Tests | QA Steps

Open Any chat on newDot which has an outstanding Payment.
Click on the Payment badge from LHN.
Now change the IOU id from URL to arbitrary value.
for example: http://localhost:8080/iou/details/68438375/rajat

Tested On

Web
Mobile Web

Screenshots

Web

iou.mp4

parasharrajat · 2021-08-10T22:28:16Z

Please confirm the Translations. Thanks

chiragsalian

Changes LGTM. Left two copy suggestions.
I'm confirming the Spanish translations with the team so waiting to hear back from them

chiragsalian · 2021-08-11T19:41:54Z

src/languages/en.js

@@ -336,8 +336,9 @@ export default {
        createGroup: 'Create Group',
    },
    notFound: {
-        chatYouLookingForCannotBeFound: 'The chat you are looking for cannot be found.',
+        chatYouLookingForCannotBeFound: 'The chat you are looking for can not be found.',


this shouldn't change. It should be,

The chat you are looking for cannot be found.

chiragsalian · 2021-08-11T19:42:40Z

src/languages/en.js

        getMeOutOfHere: 'Get me out of here',
+        iouReportNotFound: 'Payment details you are looking for can not be found.',


I would rephrase this to be,

The payment details you are looking for cannot be found.

parasharrajat · 2021-08-11T21:46:36Z

@chiragsalian Changes done.

parasharrajat · 2021-08-12T19:49:28Z

@chiragsalian Friendly ping.

chiragsalian · 2021-08-12T19:59:05Z

Yup i've posted about the spanish copy in one of our slack channels and we haven't landed on a resolution. Shall update you as soon as i get an update. Let me bump them.

chiragsalian

Alright they replied, posted.

chiragsalian · 2021-08-12T20:12:16Z

src/languages/es.js

@@ -336,8 +336,9 @@ export default {
        createGroup: 'Crear Grupo',
    },
    notFound: {
-        chatYouLookingForCannotBeFound: 'No se pudo encontrar el chat que estabas buscando.',
+        chatYouLookingForCannotBeFound: 'No se pudo encontrar el chat que está buscando.',


Can you change this to,

El chat que estás buscando no se ha podido encontrar.

chiragsalian · 2021-08-12T20:13:57Z

src/languages/es.js

        getMeOutOfHere: 'Sácame de aquí',
+        iouReportNotFound: 'No se pudo encontrar los detalles de pago que está buscando.',


Can you change this to,

Los detalles del pago que estás buscando no se han podido encontrar.

chiragsalian · 2021-08-12T20:15:01Z

src/languages/en.js

@@ -338,6 +338,7 @@ export default {
    notFound: {
        chatYouLookingForCannotBeFound: 'The chat you are looking for cannot be found.',
        getMeOutOfHere: 'Get me out of here',
+        iouReportNotFound: 'Payment details you are looking for cannot be found.',


Also the change i suggested here earlier doesn't seem to be applied, Basically, i suggest that it begins with,

The

so the complete text looks like,

The payment details you are looking for cannot be found.

parasharrajat · 2021-08-12T22:22:43Z

@chiragsalian Done.

chiragsalian

thank you

OSBotify · 2021-08-12T23:21:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-08-17T18:52:54Z

🚀 Deployed to staging by @chiragsalian in version: 1.0.85-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-08-25T17:34:10Z

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

OSBotify · 2021-08-25T17:55:38Z

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

botify · 2021-08-30T17:21:20Z

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

handle Undefined IOU Id on IOUdetails page

85ba365

parasharrajat requested a review from a team as a code owner August 10, 2021 22:27

MelvinBot requested review from chiragsalian and removed request for a team August 10, 2021 22:27

chiragsalian reviewed Aug 11, 2021

View reviewed changes

translations

a79e799

chiragsalian reviewed Aug 12, 2021

View reviewed changes

translations

109a2c8

chiragsalian approved these changes Aug 12, 2021

View reviewed changes

chiragsalian merged commit 0c6c942 into Expensify:main Aug 12, 2021

This was referenced Aug 13, 2021

Deploy Checklist: Expensify.cash 2021-08-11 #4554

Closed

Deploy Checklist: New Expensify 2021-08-17 #4701

Closed

		getMeOutOfHere: 'Get me out of here',
		iouReportNotFound: 'Payment details you are looking for can not be found.',

		getMeOutOfHere: 'Sácame de aquí',
		iouReportNotFound: 'No se pudo encontrar los detalles de pago que está buscando.',

Handle undefined IOU Report on IOUdetails page #4534

Handle undefined IOU Report on IOUdetails page #4534

Uh oh!

Conversation

parasharrajat commented Aug 10, 2021

Details

Fixed Issues

Tests | QA Steps

Tested On

Screenshots

Web

Uh oh!

parasharrajat commented Aug 10, 2021

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

chiragsalian Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

chiragsalian Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Aug 11, 2021

Uh oh!

parasharrajat commented Aug 12, 2021

Uh oh!

chiragsalian commented Aug 12, 2021

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

chiragsalian Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

chiragsalian Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

chiragsalian Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Aug 12, 2021

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 12, 2021

Uh oh!

OSBotify commented Aug 17, 2021

Uh oh!

botify commented Aug 25, 2021

Uh oh!

OSBotify commented Aug 25, 2021

Uh oh!

botify commented Aug 30, 2021

Uh oh!

Uh oh!