fix RHP animation on Safari #44840

Kicu · 2024-07-04T15:04:01Z

Details

hotfix for the bug with RHP screens
Stop using interpolator from react-navigation for RHP because it seems to be the source of the bug on Safari
instead use an interpolator that was already written and used in another place

Fixed Issues

$ #44765
PROPOSAL:

Tests

verify opening RHP and navigating within it
flow: FAB -> Assign Task -> Next
flow: Report -> ReportDetails -> ShareScreen
flow: Search -> click on any row -> ReportDetails (click on header inside RHP)

Offline tests

QA Steps

verify opening RHP and navigating within it
flow: FAB -> Assign Task -> Next
flow: Report -> ReportDetails -> ShareScreen
flow: Search -> click on any row -> ReportDetails (click on header inside RHP)

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Chrome

rec-web-chrome-bug.mp4

Safari

rec-web-safari-bug.mp4

MacOS: Desktop

melvin-bot · 2024-07-04T15:04:12Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kicu · 2024-07-04T15:05:11Z

@mountiny this is the fix, please take a look - perhaps we could run a build here and test it?
I have tested locally on Safari and did not get the bug

CC @ShridharGoel @s77rt

ShridharGoel · 2024-07-04T15:52:47Z

This doesn't seem to fix the issue:

Screen.Recording.2024-07-04.at.9.19.06.PM.mov

s77rt · 2024-07-04T18:18:02Z

cc @ishpaul777 (#44765 (comment))

ishpaul777 · 2024-07-04T18:28:24Z

Sadly, these does not fixed the issue for me

Screen.Recording.2024-07-04.at.11.54.33.PM.mov

Kicu · 2024-07-05T06:44:39Z

I see, it's a shame that this doesn't solve the bug.

However the funny thing is that this solves it for me 100%. I literally cannot trigger the bug anymore which means I can't try to fix it anymore 😓

Check my video. Interestingly if you look at the period around 0:25 - 0:40 you can see the very similar faulty animation - but for me it always comes back to correct layout. But I still think its these interpolators that break it.

rec-web-safair-bug2.mp4

Not sure what to do next, since I cannot reproduce it anymore - either via clicking or via keyboard and I tried multiple types of RHP modals.
One more thing to try: There is a few more places where we use CardStyleInterpolators.forHorizontalIOS - people that still see the bug could try to remove it everywhere and see if this helps?

Btw I'm on mac M3 Pro, Sonoma v14.4.1, Safari v17.14.1

mountiny · 2024-07-05T09:22:30Z

I can still reliably repro on this branch as well when going from the task title to confirmation page
https://github.com/Expensify/App/assets/36083550/95bdff9d-5c11-49bb-b712-fa2cde2e31de

@Kicu nobody in SWM can reproduce this?

Kicu · 2024-07-05T11:56:51Z

This PR is now using the custom interpolators only for Safari as a temporary solution, until we can fix all the animations correctly.

ishpaul777 · 2024-07-05T13:13:25Z

src/libs/Navigation/AppNavigator/ModalStackNavigators/useModalScreenOptions.ts

 import useThemeStyles from '@hooks/useThemeStyles';
+import useWindowDimensions from '@hooks/useWindowDimensions';
+import {isSafari} from '@libs/Browser';


NAB, we usually import libs like this

import * as Browser from '@libs/Browser';

sorry forgot to change this, lets just keep as is - this code is supposed to go away soon when we have a better solution. Will keep this in mind for future

ishpaul777 · 2024-07-05T13:17:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Not affected

Android: mWeb Chrome

not affected

iOS: Native

Not affected

iOS: mWeb Safari

Screen.Recording.2024-07-05.at.6.35.39.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-05.at.6.29.44.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-05.at.6.38.20.PM.mov

src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

Kicu · 2024-07-05T14:02:44Z

@ishpaul777 PR updated, pushed a with commit with usememo

ishpaul777 · 2024-07-05T14:04:44Z

src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

+        // The .forHorizontalIOS interpolator from `@react-navigation` is misbehaving on Safari, so we override it with Expensify custom interpolator
+        if (isSafari()) {
+            const customInterpolator = createModalCardStyleInterpolator(styleUtils);
+            screenOptions.cardStyleInterpolator = (props: StackCardInterpolationProps) => customInterpolator(isSmallScreenWidth, false, false, props);


Suggested change

screenOptions.cardStyleInterpolator = (props: StackCardInterpolationProps) => customInterpolator(isSmallScreenWidth, false, false, props);

options.cardStyleInterpolator = (props: StackCardInterpolationProps) => customInterpolator(isSmallScreenWidth, false, false, props);

done, thank you for catching this, I was kinda rushing it 😓

ishpaul777

we just need to apply suggestion rest looks good! Approving since I have go offline for few hours. @mountiny Can you please handle it forward.

Kicu · 2024-07-05T14:12:43Z

Please be advised that the test failure on this PR is most likely because of the file CIGitLogicTest - you can read more context here: #44123

I have not touched any logic related to the files that are failing

mountiny

Thanks!

OSBotify · 2024-07-05T18:11:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:58:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:55:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:06:56Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:25:38Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix RHP animation on Safari

0f24747

Kicu marked this pull request as ready for review July 4, 2024 15:04

Kicu requested a review from a team as a code owner July 4, 2024 15:04

melvin-bot bot requested review from s77rt and removed request for a team July 4, 2024 15:04

Kicu mentioned this pull request Jul 4, 2024

[CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod #44765

Closed

6 tasks

mountiny self-requested a review July 4, 2024 22:20

mountiny assigned Kicu Jul 5, 2024

Kicu added 2 commits July 5, 2024 13:01

use custom interpolator also for Modal Stack navigators

60835a0

use custom interpolators only for Safari

eb92f58

mountiny added the Ready To Build label Jul 5, 2024

mountiny requested review from ishpaul777 and removed request for s77rt July 5, 2024 13:12

ishpaul777 reviewed Jul 5, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx Outdated Show resolved Hide resolved

fix custom interpolator for Safari after review

151c8a9

ishpaul777 reviewed Jul 5, 2024

View reviewed changes

ishpaul777 approved these changes Jul 5, 2024

View reviewed changes

fix custom interpolator for Safari after review

cabac7e

ishpaul777 approved these changes Jul 5, 2024

View reviewed changes

mountiny approved these changes Jul 5, 2024

View reviewed changes

mountiny merged commit 45f76be into Expensify:main Jul 5, 2024
13 of 15 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

	screenOptions.cardStyleInterpolator = (props: StackCardInterpolationProps) => customInterpolator(isSmallScreenWidth, false, false, props);
	options.cardStyleInterpolator = (props: StackCardInterpolationProps) => customInterpolator(isSmallScreenWidth, false, false, props);

fix RHP animation on Safari #44840

fix RHP animation on Safari #44840

Uh oh!

Conversation

Kicu commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Chrome

Safari

Uh oh!

melvin-bot bot commented Jul 4, 2024

Uh oh!

Kicu commented Jul 4, 2024

Uh oh!

ShridharGoel commented Jul 4, 2024

Uh oh!

s77rt commented Jul 4, 2024

Uh oh!

ishpaul777 commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kicu commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jul 5, 2024

Uh oh!

Kicu commented Jul 5, 2024

Uh oh!

ishpaul777 Jul 5, 2024

Choose a reason for hiding this comment

Uh oh!

Kicu Jul 5, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Kicu commented Jul 5, 2024

Uh oh!

ishpaul777 Jul 5, 2024

Choose a reason for hiding this comment

Uh oh!

Kicu Jul 5, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

Kicu commented Jul 5, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 5, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

Uh oh!

Kicu commented Jul 4, 2024 •

edited

Loading

ishpaul777 commented Jul 4, 2024 •

edited

Loading

Kicu commented Jul 5, 2024 •

edited

Loading

ishpaul777 commented Jul 5, 2024 •

edited

Loading