Skip to content

Fix/ Zeros are added to currency that does not support decimal #43816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Fix/ Zeros are added to currency that does not support decimal #43816

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f144f54
Fixing form amount inconsistency with some currencies
abzokhattab Jun 16, 2024
c8d5332
Fixing linting
abzokhattab Jun 16, 2024
5fa91a9
Refactoring
abzokhattab Jun 24, 2024
0b59764
Merge remote-tracking branch 'origin/main' into fix-amount-inconsiste…
abzokhattab Jul 3, 2024
e17952a
Type refactoring: making currency as required in the convertToFronten…
abzokhattab Jul 8, 2024
39588a6
Merge remote-tracking branch 'origin/main' into fix-amount-inconsiste…
abzokhattab Jul 15, 2024
2a77d9c
minor edit
abzokhattab Jul 15, 2024
4c934fc
making currency as required
abzokhattab Jul 15, 2024
49315c3
Minor
abzokhattab Jul 16, 2024
3bb57a6
Minor edit
abzokhattab Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MoneyRequestAmountInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type MoneyRequestAmountInputProps = {
amount?: number;

/** A callback to format the amount number */
onFormatAmount?: (amount: number, currency?: string) => string;
onFormatAmount?: (amount: number, currency: string) => string;

/** Currency chosen by user or saved in Onyx */
currency?: string;
Expand Down Expand Up @@ -106,7 +106,7 @@ const getNewSelection = (oldSelection: Selection, prevLength: number, newLength:
return {start: cursorPosition, end: cursorPosition};
};

const defaultOnFormatAmount = (amount: number, currency?: string) => CurrencyUtils.convertToFrontendAmountAsString(amount, currency ?? CONST.CURRENCY.USD);
const defaultOnFormatAmount = (amount: number, currency: string) => CurrencyUtils.convertToFrontendAmountAsString(amount, currency ?? CONST.CURRENCY.USD);

function MoneyRequestAmountInput(
{
Expand Down
5 changes: 4 additions & 1 deletion src/pages/iou/request/IOURequestStartPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ function IOURequestStartPage({
{shouldDisplayDistanceRequest && <TopTab.Screen name={CONST.TAB_REQUEST.DISTANCE}>{() => <IOURequestStepDistance route={route} />}</TopTab.Screen>}
</OnyxTabNavigator>
) : (
<IOURequestStepAmount route={route} />
<IOURequestStepAmount
route={route}
shouldKeepUserInput
/>
)}
</View>
</DragAndDropProvider>
Expand Down
Loading