-
Notifications
You must be signed in to change notification settings - Fork 3.2k
IOU Error Handling, navigated back to Amount Page on error #4378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU Error Handling, navigated back to Amount Page on error #4378
Conversation
@thienlnam translation needed for |
Translations: Invalid Amount > |
Updated the translations above ^ |
@thienlnam Done check and let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Just one small comment
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@thienlnam I didn’t remove methods yet |
@Santhosh-Sellavel That is my bad, accidentally merged - can you spin up another PR disabling eslint and removing the method? |
Sure I'm On it. |
🚀 Deployed to staging in version: 1.0.82-8🚀
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
@thienlnam
Details
Fixed Issues
#4130
Tests & QA Steps
##Handling
On Error will take the user back to the amount page, an appropriate error notification will be shown.
Tested On
Screenshots
Web
IOU_Error_Handling_Web.mov
Mobile Web
IOU_Error_Handling_mWeb.mov
Desktop
IOU_Error_Handling_Desktop.mov
iOS
IOU_Error_Handling_iOS.mov