-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix bolded text for Existing Owners Error #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to get it tested on Android?
@tgolen My android emulator is being all wonky. I have an old android device lying around somewhere, lemme see if I can find it 🧐 |
Ah, cool. Thanks! Sorry it gave you such fits. I know the pain |
I assume the removal of flex was intentional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll must assume you meant to remove the flex and merge this. If we need to revert that change in another PR (like if it was a mistake), then that's OK.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.81-5🚀
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
Details
This PR fixes the text in the error message to prevent any separators (e.g.
,
,, and
, etc.) from being bolded. It also ensures we use the localization for the wordand
.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/169896#issuecomment-884327715
Tests
QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
cc @michelle-thompson