Skip to content

Correct emoji presentation on emoji picker #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Correct emoji presentation on emoji picker #4206

merged 2 commits into from
Jul 26, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jul 24, 2021

Details

Fixes an issue where some emojis would be displayed in its text style. We add the VS16 unicode to our emojis to get the correct variant.

Fixed Issues

$ #4147

Tests

QA Steps

  1. Open any chat
  2. Click on the emoji picker
  3. Search for the the Skull and Crossbones emoji (or any other reported on the issue)
  4. It should match the Skull and Crossbones emoji of your system

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mp4

Desktop

desktop.mov

iOS

iOS.mp4

Android

Android.mp4

@rdjuric rdjuric marked this pull request as ready for review July 24, 2021 06:33
@rdjuric rdjuric requested a review from a team as a code owner July 24, 2021 06:33
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team July 24, 2021 06:34
@thienlnam thienlnam merged commit 001f285 into Expensify:main Jul 26, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants