Skip to content

Revert "Handle emoji tooltip" #37778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Revert "Handle emoji tooltip" #37778

merged 1 commit into from
Mar 5, 2024

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 5, 2024

Reverts #35838

Straight revert

Fixes

$ #37738
$ #37749

@roryabraham roryabraham requested a review from a team as a code owner March 5, 2024 18:22
@roryabraham roryabraham changed the title Revert "Handle emoji tooltip" [HOLD] Revert "Handle emoji tooltip" Mar 5, 2024
@melvin-bot melvin-bot bot requested review from blimpich and removed request for a team March 5, 2024 18:22
Copy link

melvin-bot bot commented Mar 5, 2024

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham roryabraham changed the title [HOLD] Revert "Handle emoji tooltip" Revert "Handle emoji tooltip" Mar 5, 2024
@roryabraham
Copy link
Contributor Author

we can skip checklists for a straight revert

@roryabraham roryabraham merged commit e1944e6 into main Mar 5, 2024
@roryabraham roryabraham deleted the revert-35838-fix/34307 branch March 5, 2024 18:52
Copy link

melvin-bot bot commented Mar 5, 2024

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Mar 5, 2024
@mkhutornyi
Copy link
Contributor

Here's evidence of fix:

ios.mov
web.mov

@roryabraham
Copy link
Contributor Author

not an emergency, skipped checklist for straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Mar 5, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Mar 5, 2024
Revert "Handle emoji tooltip"

(cherry picked from commit e1944e6)
@OSBotify
Copy link
Contributor

OSBotify commented Mar 5, 2024

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.47-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants