Fix crash when expanding video player #37772

bernhardoj · 2024-03-05T16:50:30Z

Details

The app crash when we expand the video player because the video player ref is null.

Fixed Issues

$ #37710
PROPOSAL: #37710 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Web/Desktop

Send a video attachment to a chat
Press the play button
Press the expand button
Verify the video shows on the attachment preview
Close the attachment preview
Repeat step 3-4

Android/iOS/mWeb

Send a video attachment to a chat
Press the play button
Verify the video shows (and plays) correctly on the attachment preview
Press back
Repeat step 3-4

(the video player on small screen works really bad right now)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-03-06.at.00.42.22.mov

iOS: Native

Screen.Recording.2024-03-06.at.00.35.42.mov

iOS: mWeb Safari

Screen.Recording.2024-03-06.at.00.37.00.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-06.at.00.18.25.mov

MacOS: Desktop

Screen.Recording.2024-03-06.at.00.21.45.mov

melvin-bot · 2024-03-05T16:50:35Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-03-05T16:52:10Z

@rushatgabhane oops, wrong linked issue. @aimane-chnaif will review this.

bernhardoj · 2024-03-05T16:53:19Z

src/components/VideoPlayer/BaseVideoPlayer.js

+        if (!isUploading) {
+            return;
+        }
+        // If we are uploading a new video, we want to immediately set the video player ref.


I use isUploading condition here because in attachment carousel with multiple video player on small screen, the video player ref is set to the wrong video player.

For example, if we have video A and B in carousel, and we open video B, it could be possible the video A video player is set as the ref when both component mounted.

aimane-chnaif · 2024-03-05T16:55:54Z

src/components/Attachments/AttachmentView/index.js

-    // This should ensure we clean up any video references when closing the attachment modal as these only existed here in memory during attachment preview.
-    useEffect(
-        () => () => {
-            if (!isVideo) {
-                return;
-            }
-            currentVideoPlayerRef.current = null;
-        },
-        [isVideo, currentVideoPlayerRef],
-    );


Please make sure that this removal doesn't cause regression of #37142.

bernhardoj · 2024-03-05T16:56:09Z

Android recording left, it's very laggy on the Android emulator. I also feel like the video player is a bit broken on mobile devices. Sometimes the video is paused randomly.

aimane-chnaif · 2024-03-05T17:19:27Z

@bernhardoj can you please perform full regression tests against these issue?

#36833
#36873 (comment)
#37142

This would be CP'ed to staging so we should be very careful.

aimane-chnaif · 2024-03-05T17:21:30Z

Lint failing

bernhardoj · 2024-03-05T17:38:43Z

#37142 : sometimes the console error shows, looks like sometimes the clearing ref useEffect is a bit late. Will check it further tomorrow. (EDIT: now I can't reproduce it at all)

To clarify, the console error that I previously saw is when closing the attachment preview by sending the attachment.
#36833 : the download options is now hidden when uploading, but even after I show it manually, it still safe
#36873 (comment) : safe

aimane-chnaif · 2024-03-05T18:07:21Z

@bernhardoj thanks. Please keep online for the next hour as this should be merged today as deploy blocker.
I am testing on all platforms right now.

pecanoro · 2024-03-05T18:25:52Z

I saw this PR is trying to clean up 2-3 PRs while trying to see what is going on with #37750. I tested the PR to see if it would fix that bug, but it doesn't, so just be aware I might need to revert #37202 and might cause some issues or conflicts with this PR

pecanoro · 2024-03-05T18:32:30Z

src/components/VideoPlayer/BaseVideoPlayer.js

+            if (shouldUseSharedVideoElementRef.current) {
+                return;
+            }
+            // If it's not a shared video player, clear the video player ref.


Suggested change

// If it's not a shared video player, clear the video player ref.

// If it's not a shared video player, clear the video player ref.

pecanoro · 2024-03-05T18:32:41Z

src/components/VideoPlayer/BaseVideoPlayer.js

+        if (!isUploading) {
+            return;
+        }
+        // If we are uploading a new video, we want to immediately set the video player ref.


Suggested change

// If we are uploading a new video, we want to immediately set the video player ref.

// If we are uploading a new video, we want to immediately set the video player ref.

aimane-chnaif · 2024-03-05T19:11:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

pecanoro

My comments can be fixed in another PR, NAB

melvin-bot · 2024-03-05T21:05:45Z

@pecanoro looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

pecanoro · 2024-03-05T21:06:08Z

Hmm, I didn't notice some checks were not passing 😢

pecanoro · 2024-03-05T21:07:25Z

Hmm, I don't see the check failing, weird, removing the label

OSBotify · 2024-03-05T21:09:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…panding-video Fix crash when expanding video player (cherry picked from commit 4ae0b42)

OSBotify · 2024-03-06T21:54:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits March 6, 2024 00:16

fix crash when expanding video player

8785827

fix lint

c82070e

bernhardoj requested a review from a team as a code owner March 5, 2024 16:50

melvin-bot bot requested review from rushatgabhane and removed request for a team March 5, 2024 16:50

bernhardoj commented Mar 5, 2024

View reviewed changes

aimane-chnaif reviewed Mar 5, 2024

View reviewed changes

prettier

346b079

pecanoro requested changes Mar 5, 2024

View reviewed changes

aimane-chnaif approved these changes Mar 5, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek March 5, 2024 19:12

pecanoro approved these changes Mar 5, 2024

View reviewed changes

pecanoro removed request for rushatgabhane and techievivek March 5, 2024 21:03

pecanoro merged commit 4ae0b42 into Expensify:main Mar 5, 2024

melvin-bot bot added the Emergency label Mar 5, 2024

pecanoro removed the Emergency label Mar 5, 2024

OSBotify pushed a commit that referenced this pull request Mar 5, 2024

Merge pull request #37772 from bernhardoj/fix/37710-app-crash-when-ex…

0302094

…panding-video Fix crash when expanding video player (cherry picked from commit 4ae0b42)

github-actions bot mentioned this pull request Mar 5, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

melvin-bot bot mentioned this pull request Mar 6, 2024

[HOLD for payment 2024-03-14] [$500] Video - App crashes when opening video in full screen while it is still loading #37710

Closed

6 tasks

bernhardoj mentioned this pull request Apr 19, 2024

[$250] Onboarding- After finishing "onboarding" and switching to DM, an error appears in the console #40458

Closed

6 tasks

	// If it's not a shared video player, clear the video player ref.

	// If it's not a shared video player, clear the video player ref.

	// If we are uploading a new video, we want to immediately set the video player ref.

	// If we are uploading a new video, we want to immediately set the video player ref.

Fix crash when expanding video player #37772

Fix crash when expanding video player #37772

Uh oh!

Conversation

bernhardoj commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 5, 2024

Uh oh!

bernhardoj commented Mar 5, 2024

Uh oh!

bernhardoj Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Mar 5, 2024

Uh oh!

aimane-chnaif commented Mar 5, 2024

Uh oh!

aimane-chnaif commented Mar 5, 2024

Uh oh!

bernhardoj commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Mar 5, 2024

Uh oh!

pecanoro commented Mar 5, 2024

Uh oh!

pecanoro Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

pecanoro Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

pecanoro left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 5, 2024

Uh oh!

pecanoro commented Mar 5, 2024

Uh oh!

pecanoro commented Mar 5, 2024

Uh oh!

OSBotify commented Mar 5, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

Uh oh!

bernhardoj commented Mar 5, 2024 •

edited

Loading

bernhardoj Mar 5, 2024 •

edited

Loading

bernhardoj commented Mar 5, 2024 •

edited

Loading

aimane-chnaif commented Mar 5, 2024 •

edited

Loading