Skip to content

Change blocked from concierge prop default to empty object #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2021
Merged

Change blocked from concierge prop default to empty object #3748

merged 1 commit into from
Jun 24, 2021

Conversation

stitesExpensify
Copy link
Contributor

Details

Just fixing a mistake from another PR

Fixed Issues

#2932 (comment)

Tests/QA Steps

  1. Log in to e.cash on an account that is not blocked
  2. Go to the concierge chat
  3. Check the console and make sure you don't see this error
Invalid prop `blockedFromConcierge` of type `string` supplied to `ReportActionCompose`, expected `object`.
    in ReportActionCompose (at withOnyx.js:154)
    ```

@stitesExpensify stitesExpensify self-assigned this Jun 24, 2021
@stitesExpensify stitesExpensify requested a review from a team as a code owner June 24, 2021 22:57
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 24, 2021 22:58
roryabraham
roryabraham approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me! 👍

@roryabraham roryabraham merged commit 3ed8538 into main Jun 24, 2021
@roryabraham roryabraham deleted the stites-fixDefault branch June 24, 2021 23:39
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jun 25, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@stitesExpensify stitesExpensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stitesExpensify @OSBotify @roryabraham