-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Categories] Add support for long category names #37389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
puneetlath
merged 15 commits into
Expensify:main
from
neonbhai:selection-list-multiline-fix
Feb 28, 2024
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
630a17e
Add prop isRowMultilineSupported to BaseSelectionList
neonbhai b7ab573
Add isMultilineSupported prop to ListItem
neonbhai 52a2fed
Add numberOfLines prop type to TextWithTooltip
neonbhai f585826
Pass isRowMultilineSupported in CategoryPicker
neonbhai 3a87b37
Pass isMultilineSupported to ListItem
neonbhai b72a521
Pass custom numberOfLines to TextWithTooltip
neonbhai c140118
Add the missing prop comments in TextWithTooltip Props
neonbhai 261ae17
Run prettier
neonbhai 3f4172c
Add default prop value to numberOfLines
neonbhai 1c7c850
Add default prop value to numberOfLines (web)
neonbhai 6d50cb5
Remove null coalescing operator in favor of default value
neonbhai 4576f78
Update src/components/SelectionList/types.ts
neonbhai d928ea0
Update src/components/SelectionList/types.ts
neonbhai 0253712
Update src/components/SelectionList/types.ts
neonbhai a3334e7
Update src/components/TextWithTooltip/types.ts
neonbhai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,17 @@ | ||
import type {StyleProp, TextStyle} from 'react-native'; | ||
|
||
type TextWithTooltipProps = { | ||
/** The text to display */ | ||
text: string; | ||
|
||
/** Whether to show the toolip text */ | ||
shouldShowTooltip: boolean; | ||
|
||
/** Additional text styles */ | ||
textStyles?: StyleProp<TextStyle>; | ||
|
||
/** Custom number of lines for Text */ | ||
neonbhai marked this conversation as resolved.
Show resolved
Hide resolved
|
||
numberOfLines?: number; | ||
}; | ||
|
||
export default TextWithTooltipProps; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.