Skip to content

Localization consts for Request Call Page #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 22, 2021
Merged

Localization consts for Request Call Page #3696

merged 7 commits into from
Jun 22, 2021

Conversation

jasperhuangg
Copy link
Contributor

This PR adds some translations for text that'll be needed when implementing the Request Call Page.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/167900

Tests

N/A

QA Steps

N/A

Tested On

N/A

@jasperhuangg jasperhuangg self-assigned this Jun 21, 2021
@jasperhuangg jasperhuangg requested a review from HorusGoul June 21, 2021 01:50
@jasperhuangg jasperhuangg marked this pull request as ready for review June 21, 2021 02:29
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 21, 2021 02:29
@MelvinBot MelvinBot requested review from tgolen and removed request for a team June 21, 2021 02:30
@jasperhuangg
Copy link
Contributor Author

@HorusGoul requesting you for review specifically for a quick double-check on the Spanish translations, thanks!

HorusGoul
HorusGoul reviewed Jun 21, 2021
View reviewed changes
@jasperhuangg
Copy link
Contributor Author

@HorusGoul Thanks for the fix! Should be good for another review, feel free to merge if you think everything checks out, thanks!!

@jasperhuangg jasperhuangg requested a review from HorusGoul June 21, 2021 11:17
HorusGoul
HorusGoul suggested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a lot of stuff on my first review. These are all the things I'd change:

jasperhuangg and others added 3 commits June 21, 2021 22:49
@jasperhuangg jasperhuangg requested a review from HorusGoul June 22, 2021 08:54
@jasperhuangg
Copy link
Contributor Author

@HorusGoul Thanks again! Should be good for another review 👍

HorusGoul
HorusGoul approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasperhuangg jasperhuangg mentioned this pull request Jun 22, 2021
Merged
5 tasks
@HorusGoul HorusGoul merged commit b42adfb into main Jun 22, 2021
@HorusGoul HorusGoul deleted the jasper-requestCallLocalization branch June 22, 2021 14:05
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jun 22, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorusGoul HorusGoul HorusGoul approved these changes

@tgolen tgolen Awaiting requested review from tgolen

Assignees

@jasperhuangg jasperhuangg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasperhuangg @OSBotify @HorusGoul