Skip to content

[No QA] fix focus state is undefined #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 19, 2021

Details

focus state was undefined as we forget to return value from it.

Credits: @kidroca for mentioning it #3551 (review).

@parasharrajat parasharrajat requested a review from a team as a code owner June 19, 2021 12:57
@MelvinBot MelvinBot requested review from tgolen and removed request for a team June 19, 2021 12:58
@parasharrajat parasharrajat changed the title [No QA] fix focus state is undefind [No QA] fix focus state is undefined Jun 19, 2021
@parasharrajat
Copy link
Member Author

@tgolen Please take a look at it, it's a minor change that was left mistakenly.

Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, oops.

@tgolen tgolen merged commit ad41508 into Expensify:main Jun 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the actionList branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants