[TS migration] Migrate 'SettingsSecurityCloseAccount' page to TypeScript #34718

VickyStash · 2024-01-18T11:27:40Z

Details

[TS migration] Migrate 'SettingsSecurityCloseAccount' page to TypeScript

Fixed Issues

$ #25186
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Log into an account you are able to close without major repercussions (ie: not an admin/owner of workspace)
Go to Settings -> Security -> Close account
Make sure Close account screen/modal looks as expected.
Fill in the message and default contact method, press Close Account
Confirm account closing, you should be redirected to the login/sign in page where the green dot message of Account closed successfully should be shown

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Log into an account you are able to close without major repercussions (ie: not an admin/owner of workspace)
Go to Settings -> Security -> Close account
Make sure Close account screen/modal looks as expected.
Fill in the message and default contact method, press Close Account
Confirm account closing, you should be redirected to the login/sign in page where the green dot message of Account closed successfully should be shown

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

filip-solecki

LGTM!

melvin-bot · 2024-01-22T11:21:53Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-01-24T12:18:59Z

Reviewing it tonight.

VickyStash · 2024-01-26T09:22:24Z

@alitoshmatov kind bump 🙂

alitoshmatov · 2024-01-29T11:20:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

closing-mweb.mov

iOS: Native

iOS: mWeb Safari

closing-safari.mp4

MacOS: Chrome / Safari

closing-web.mov

MacOS: Desktop

closing-desktop.mov

alitoshmatov

LGTM!

melvin-bot · 2024-01-29T12:58:32Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25186 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

flodnv · 2024-01-29T15:20:10Z

Hi, I will review and merge this

flodnv · 2024-01-29T15:33:55Z

src/pages/settings/Security/CloseAccountPage.tsx

        const requiredFields = ['phoneOrEmail'];
-        const userEmailOrPhone = props.formatPhoneNumber(props.session.email);
+        const userEmailOrPhone = formatPhoneNumber(session?.email ?? '');


Why wouldn't we have an email here?

Since session goes from Onyx it has null in the typing. Email is also option field in the session, so to prevent TS error we need to add default value, but I can try to update formatPhoneNumber typing instead, let me try

@flodnv Done, what do you think?

As a noob, I want to try to understand more about this. I wanted to spin up a discussion in #expensify-open-source in Slack and tag you but I failed to find you on Slack, what is your handle?

@flodnv You can find me as Viktoryia Kliushun, I've also pinged you in Slack so you should see me there
@fabioh8010 @blazejkustra It would be great to here your thoughts on this one since we have doubts

@flodnv In this component session is a Onyx prop supplied by withOnyx and therefore can be null as any other Onyx value, so we can either default the value to '' or change formatPhoneNumber to accept and handle undefined values too. Looks like @VickyStash already changed formatPhoneNumber to support it and I think it's the best approach, wdyt?

flodnv · 2024-01-29T15:34:05Z

src/pages/settings/Security/CloseAccountPage.tsx

@@ -82,59 +78,59 @@ function CloseAccountPage(props) {
        return errors;
    };

-    const userEmailOrPhone = props.formatPhoneNumber(props.session.email);
+    const userEmailOrPhone = formatPhoneNumber(session?.email ?? '');


same question

VickyStash · 2024-01-30T11:00:20Z

@flodnv kind bump 🙂

# Conflicts: # src/types/onyx/Form.ts

# Conflicts: # src/types/onyx/Form.ts # src/types/onyx/index.ts

# Conflicts: # src/pages/settings/Security/CloseAccountPage.tsx # src/types/onyx/index.ts

VickyStash · 2024-02-02T10:14:55Z

@flodnv hey, kind bump 🙂

flodnv · 2024-02-02T14:35:28Z

Sorry for the delay, the last few days have been very busy for me and I've been working part time. Looking at this now.

flodnv

Thank you

OSBotify · 2024-02-02T14:41:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T22:53:30Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] Migrate 'SettingsSecurityCloseAccount' page

4c04f9b

kubabutkiewicz approved these changes Jan 18, 2024

View reviewed changes

filip-solecki approved these changes Jan 22, 2024

View reviewed changes

VickyStash marked this pull request as ready for review January 22, 2024 11:21

VickyStash requested a review from a team as a code owner January 22, 2024 11:21

melvin-bot bot requested review from alitoshmatov and removed request for a team January 22, 2024 11:21

VickyStash added 2 commits January 25, 2024 16:49

Merge branch 'main' into ts-migration/settingsSecurityCloseAccount-page

1a23531

Remove extra TODOs, add CloseAccountForm type

d788f79

alitoshmatov approved these changes Jan 29, 2024

View reviewed changes

flodnv reviewed Jan 29, 2024

View reviewed changes

VickyStash added 3 commits January 29, 2024 17:40

Update formatPhoneNumber typing

fc2ab2b

Merge branch 'main' into ts-migration/settingsSecurityCloseAccount-page

9b4b547

Fix Onyx types import

8c4b3d0

VickyStash added 5 commits January 31, 2024 11:25

Merge branch 'main' into ts-migration/settingsSecurityCloseAccount-page

04b269a

# Conflicts: # src/types/onyx/Form.ts

Merge branch 'main' into ts-migration/settingsSecurityCloseAccount-page

026d292

# Conflicts: # src/types/onyx/Form.ts # src/types/onyx/index.ts

Lint fix

39ef206

Merge branch 'main' into ts-migration/settingsSecurityCloseAccount-page

66e38c6

# Conflicts: # src/pages/settings/Security/CloseAccountPage.tsx # src/types/onyx/index.ts

Fix lint error

d2f71a8

flodnv approved these changes Feb 2, 2024

View reviewed changes

flodnv merged commit 546df83 into Expensify:main Feb 2, 2024

flodnv mentioned this pull request Feb 2, 2024

[$250] [TS migration] Migrate 'SettingsSecurityCloseAccount' page to TypeScript #25186

Closed

github-actions bot mentioned this pull request Feb 2, 2024

Deploy Checklist: New Expensify 2024-02-02 #35673

Closed

lanitochka17 mentioned this pull request Feb 2, 2024

[$500] Web - Preferences, Security, About, Workspaces animations are missing #35687

Closed

6 tasks

[TS migration] Migrate 'SettingsSecurityCloseAccount' page to TypeScript #34718

[TS migration] Migrate 'SettingsSecurityCloseAccount' page to TypeScript #34718

Uh oh!

Conversation

VickyStash commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

filip-solecki left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 22, 2024

Uh oh!

alitoshmatov commented Jan 24, 2024

Uh oh!

VickyStash commented Jan 26, 2024

Uh oh!

alitoshmatov commented Jan 29, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 29, 2024

Uh oh!

flodnv commented Jan 29, 2024

Uh oh!

flodnv Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

VickyStash Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

VickyStash Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

flodnv Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

VickyStash Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

flodnv Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Jan 30, 2024

Uh oh!

VickyStash commented Feb 2, 2024

Uh oh!

flodnv commented Feb 2, 2024

Uh oh!

flodnv left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 2, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

Uh oh!

VickyStash commented Jan 18, 2024 •

edited

Loading

VickyStash Jan 31, 2024 •

edited

Loading