-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Set the focus on Edit Box after edit action. #3441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8737fb4
set the focus on the Edit ox on edit action
parasharrajat b607356
pull latest changes
parasharrajat 0a62b81
fix: callback needs to reset for each action
parasharrajat 1910616
Merge branch 'main' of github.com:Expensify/Expensify.cash into edit-box
parasharrajat f60fdf9
added a new composer focus strategy
parasharrajat 713dfb0
fix: bug transItionEnd does not fire on IOS
parasharrajat fecc303
Merge branch 'main' of github.com:Expensify/Expensify.cash into edit-box
parasharrajat 43bf806
tweaks
parasharrajat fda1967
typo
parasharrajat 65662dd
fix: prop name
parasharrajat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import _ from 'underscore'; | ||
|
||
let focusCallback = null; | ||
|
||
/** | ||
* Register a callback to be called when focus is requested. | ||
* Typical uses of this would be call the focus on the ReportActionComposer. | ||
* | ||
* @param {Function} callback callback to register | ||
*/ | ||
function onComposerFocus(callback) { | ||
focusCallback = callback; | ||
} | ||
|
||
/** | ||
* Request focus on the ReportActionComposer | ||
* | ||
*/ | ||
function focus() { | ||
if (_.isFunction(focusCallback)) { | ||
focusCallback(); | ||
} | ||
} | ||
|
||
/** | ||
* Clear the registered focus callback | ||
* | ||
*/ | ||
function clear() { | ||
focusCallback = null; | ||
} | ||
|
||
export default { | ||
onComposerFocus, | ||
focus, | ||
clear, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.