-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Replacing the 'import from spreadsheet' screenshot for an article #31497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A preview of your ExpensifyHelp changes have been deployed to https://a753bc9b.helpdot.pages.dev ⚡️ |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@johncschuster Please, wait until the reviewer merges it next time, I was waiting for all checklists to pass and testing it. |
Oooooh, sorry about that! I noticed one of the automated tests hadn't passed, but it seemed to be because it hadn't detected your reviewer checklist being completed. I re-ran the automated test, and it cleared, so I thought it was cool to merge the pr. I won't do that again! |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀
|
Per this comment, @RachCHopkins noticed that the current image in the article does not use our accessible color palette for the arrow in the screenshot. I've replicated the image and changed the arrow to use one of our accessible colors.
I've deleted the old file, and have uploaded the new file with the same name and path as the old file to ensure I don't break any of the articles that reference this file.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop