-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
neil-marcellini
merged 14 commits into
Expensify:main
from
VickyStash:ts-migration/app-lib
Nov 9, 2023
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9e5dbf3
[TS migration] Migrate 'App.js' lib
VickyStash 2d4e87c
Merge branch 'main' into ts-migration/app-lib
VickyStash 8b55df1
Update typing after API file was migrated to TS
VickyStash 89791d4
Merge branch 'main' into ts-migration/app-lib
VickyStash 935c2df
Minor code improvements
VickyStash aab400b
Merge branch 'main' into ts-migration/app-lib
VickyStash 103d4af
Run linter after merging main
VickyStash 25e9ec7
Fix ts error
VickyStash b9c9bc1
Merge branch 'main' into ts-migration/app-lib
VickyStash fd0b267
Merge branch 'main' into ts-migration/app-lib
VickyStash f6ccc56
Remove extra optional chaining
VickyStash 32913c1
Merge branch 'main' into ts-migration/app-lib
VickyStash 062d120
Get rid of extra nullish coalescing operators
VickyStash 6955074
Remove extra comment
VickyStash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,15 @@ | ||
function getBrowser() { | ||
return ''; | ||
} | ||
import type {GetBrowser, IsMobile, IsMobileChrome, IsMobileSafari, IsSafari, OpenRouteInDesktopApp} from './types'; | ||
|
||
function isMobile() { | ||
return false; | ||
} | ||
const getBrowser: GetBrowser = () => ''; | ||
|
||
function isMobileSafari() { | ||
return false; | ||
} | ||
function isMobileChrome() { | ||
return false; | ||
} | ||
const isMobile: IsMobile = () => false; | ||
|
||
function isSafari() { | ||
return false; | ||
} | ||
const isMobileSafari: IsMobileSafari = () => false; | ||
|
||
function openRouteInDesktopApp() {} | ||
const isMobileChrome: IsMobileChrome = () => false; | ||
|
||
const isSafari: IsSafari = () => false; | ||
|
||
const openRouteInDesktopApp: OpenRouteInDesktopApp = () => {}; | ||
|
||
export {getBrowser, isMobile, isMobileSafari, isSafari, isMobileChrome, openRouteInDesktopApp}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
type GetBrowser = () => string; | ||
|
||
type IsMobile = () => boolean; | ||
|
||
type IsMobileSafari = () => boolean; | ||
|
||
type IsMobileChrome = () => boolean; | ||
|
||
type IsSafari = () => boolean; | ||
|
||
type OpenRouteInDesktopApp = (shortLivedAuthToken?: string, email?: string) => void; | ||
|
||
export type {GetBrowser, IsMobile, IsMobileSafari, IsMobileChrome, IsSafari, OpenRouteInDesktopApp}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.